-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grub2-mkconfig failing on F29 #1598
Comments
Dup of #1567 ? |
I think so see #1567 (comment) micah can you |
I don't think it's a dupe. If you look at projectatomic/atomic-host-tests#437 (comment), you can see it's not failing from a timeout, but from |
Yeah, @jlebon is onto something
|
|
Ugh, the sooner we can get rid of I wonder if we're potentially racing with |
well that looks like a smoking gun :) |
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d4d38d8885 Adam Williamson reporting problems in OpenQA there, too |
micah can you run the transaction and then run |
|
good to know. can we add bad karma to that update? |
Will do |
There's a bigger picture issue here in that I am doubtful that the boot-counting implementation that ships in grub as it exists today is something we want for Fedora {Atomic Host, CoreOS}. |
We could try just nuking those bits in |
👍 assuming there isn't an rpm that we can easily just yank out |
This is possibly caused by https://bugzilla.redhat.com/show_bug.cgi?id=1614637 I made a PR to fix it here: rhboot/grub2#42 With the current implementation it is required to do the following in userspace (this is how greenboot intends to do it, too). On a successful boot (could also be run as a one-shot service when using proposed system-boot-success.target/boot-complete.target and reaching it):
On OS upgrade to activate the boot counter:
@cgwalters what are your thoughts on a boot counting implementation, i.e. what would it look like if not the way it is now? I'd once again like to start a broader discussion around this! |
Let's track that discussion in coreos/fedora-coreos-config#21 ? |
Ack. The explanatory part in the comment above also plays into: coreos/fedora-coreos-tracker#47 |
Closing as this is tracked elsewhere. |
Our automated tests caught this on Fedora 29 Atomic Host, starting from
fedora/29/x86_64/testing/atomic-host
ref. After installingwget
and rebooting, the pending deployment scheduled for next boot is gone.From the journal where the transaction happened:
I know @jlebon was digging into this a bit after seeing results off projectatomic/atomic-host-tests#437, but wanted to get this logged
The text was updated successfully, but these errors were encountered: