-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Drop grub2 auto-hide and boot counting bits #21
Conversation
There's a typo here, you've got 01_ both inside and outside the brackets. |
The design where "boot success" is "interactive user login" doesn't match well with our expected use case. Plus, I think the boot menu hiding clashes with the ostree value proposition.
3e71a91
to
808e404
Compare
Thanks for catching that! I updated this to use While you're here @vathpela - we're basically going into the guts of grub here and removing part of it, as best I can tell the functionality is encapsulated in those files, but please keep this in mind going forward. There's a lot of interacting things here - the idea seems nice for desktops, but for servers we really want to see the console. I also just want to wait to have some time to validate all of the interactions with ostree myself, or have confidence that someone else has done it. We're almost certain to look at the boot counting stuff, just not right now. |
LGTM |
@cgwalters with current rpm build grub2-2.02-62.fc29 this will fail as the boot counting part has been (temporarily) removed from the package: https://src.fedoraproject.org/rpms/grub2/c/7c415d82878e13fcd626a9cbd3a336e208f15d33. |
@LorbusChris was that part of the work you did during GSOC? you're saying we don't need this PR now? |
@dustymabe Yes, it was. It was merged prematurely, though, and has not yet worked the way intended. |
@dustymabe and to answer the question: If we want to remove these two scripts, we will need this PR as is as soon as rhboot/grub2#42 unblocks it. |
Update: The code got merged again, but hasn't yet made it into the rpm. I'm tracking this. |
cc @LorbusChris - what should we do with this PR. Still waiting on something? Should we close it? |
@dustymabe grub2 in F29 does contain the menu hide script:
we probably still want to drop that. |
Also, we will need this when we begin composing F30 packages. |
# The grub bits are mainly designed for desktops, and IMO haven't seen | ||
# enough testing in concert with ostree. At some point we'll flesh out | ||
# the full plan in https://github.com/coreos/fedora-coreos-tracker/issues/47 | ||
rm -v /etc/grub.d/01_{fallback_counting,menu_auto_hide} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this line to:
rm -v /etc/grub.d/01_menu_auto_hide
should suffice for now
so we will also need this for F30 (that's the only target I'm concerned with for now)? If so let's fixup this PR or open a new PR. WDYT? |
fixed in #36, also added a TODO to add back removal of fallback script in f30. |
cloud.ks: Switch to RHELAH kickstart
This adds a user-guide for custom sysctl settings.
The design where "boot success" is "interactive user login"
doesn't match well with our expected use case. Plus, I think
the boot menu hiding clashes with the ostree value proposition.