crash at end of rebase #30

cgwalters · 2014-09-25T18:51:34Z

This happened at the end of an "atomic rebase foo:".

       PID: 836 (atomic)
       UID: 0 (root)
       GID: 0 (root)
    Signal: 11 (SEGV)
 Timestamp: Thu 2014-09-25 18:03:21 UTC (47min ago)

Command Line: atomic rebase local:
Executable: /usr/bin/rpm-ostree
Control Group: /user.slice/user-1000.slice/session-1.scope
Unit: session-1.scope
Slice: user-1000.slice
Session: 1
Owner UID: 1000 (walters)
Boot ID: 6e1f2de7f9114eba9275cbf00de7f87a
Machine ID: 45bb3b96146aa94f299b9eb43646eb35
Hostname: localhost.localdomain
Coredump: /var/lib/systemd/coredump/core.atomic.0.6e1f2de7f9114eba9275cbf00de7f87a.836.1411668201000000.xz
Message: Process 836 (atomic) of user 0 dumped core.

            Stack trace of thread 836:
            #0  0x00007fe8f0782aba g_list_remove_link (libglib-2.0.so.0)
            #1  0x00007fe8f077d128 g_key_file_remove_group_node (libglib-2.0.so.0)
            #2  0x00007fe8f077d284 g_key_file_clear (libglib-2.0.so.0)
            #3  0x00007fe8f077f149 g_key_file_unref (libglib-2.0.so.0)
            #4  0x00007fe8f127d7b3 ostree_deployment_finalize (libostree-1.so.1)
            #5  0x00007fe8f0a8ad86 g_object_unref (libgobject-2.0.so.0)
            #6  0x00007fe8f127c651 ostree_sysroot_upgrader_finalize (libostree-1.so.1)
            #7  0x00007fe8f0a8ad86 g_object_unref (libgobject-2.0.so.0)
            #8  0x0000000000407d5b rpmostree_builtin_rebase (rpm-ostree)
            #9  0x000000000040697a main (rpm-ostree)
            #10 0x00007fe8ef3f90e0 __libc_start_main (libc.so.6)
            #11 0x0000000000406b74 _start (rpm-ostree)

The text was updated successfully, but these errors were encountered:

This crashes for me sometimes, so let's add a test. #30

We unref it in _finalize, so we need to hold a ref. I *thought* this was the source of coreos/rpm-ostree#30 But apparently not =/

cgwalters · 2014-09-30T15:02:39Z

This was https://git.gnome.org/browse/ostree/commit/?id=1b8759a67e7705b2dba4b6c4d99e0c7b0b82da41

I think this changed in a recent refactoring; basically since we're passing this stack-allocated value to the child spawn function we need to keep it alive. This of course would have been caught by Rust... ``` ==672376==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffc290d9440 at pc 0x55c88c318946 bp 0x7ffc290d8b10 sp 0x7ffc290d8b08 #0 0x55c88c318945 in script_child_setup src/libpriv/rpmostree-scripts.cxx:272 #1 0x7f92089da902 (/lib64/libglib-2.0.so.0+0x9f902) #2 0x7f92089de20f (/lib64/libglib-2.0.so.0+0xa320f) #3 0x7f92089de52e (/lib64/libglib-2.0.so.0+0xa352e) #4 0x7f92089def02 in g_spawn_async_with_pipes (/lib64/libglib-2.0.so.0+0xa3f02) #5 0x7f9208b7445f (/lib64/libgio-2.0.so.0+0xab45f) #6 0x7f9208b736d8 in g_subprocess_launcher_spawnv (/lib64/libgio-2.0.so.0+0xaa6d8) #7 0x55c88c3831b9 in rpmostree_bwrap_execute src/libpriv/rpmostree-bwrap.cxx:504 #8 0x55c88c3836df in rpmostree_bwrap_run_captured src/libpriv/rpmostree-bwrap.cxx:450 #9 0x55c88c31b5f1 in rpmostree_run_script_in_bwrap_container src/libpriv/rpmostree-scripts.cxx:469 #10 0x55c88c31ca9d in impl_run_rpm_script src/libpriv/rpmostree-scripts.cxx:588 #11 0x55c88c31d22b in run_script src/libpriv/rpmostree-scripts.cxx:637 #12 0x55c88c31d22b in rpmostree_script_run_sync src/libpriv/rpmostree-scripts.cxx:778 #13 0x55c88c2ef830 in run_script_sync src/libpriv/rpmostree-core.cxx:3661 #14 0x55c88c30afa6 in rpmostree_context_assemble src/libpriv/rpmostree-core.cxx:4422 #15 0x55c88c34a9af in install_packages src/app/rpmostree-compose-builtin-tree.cxx:451 #16 0x55c88c34c174 in impl_install_tree src/app/rpmostree-compose-builtin-tree.cxx:925 #17 0x55c88c350f84 in rpmostree_compose_builtin_tree src/app/rpmostree-compose-builtin-tree.cxx:1421 #18 0x55c88c276ec8 in rpmostree_handle_subcommand src/app/libmain.cxx:405 #19 0x55c88c27827c in rpmostree_main_inner src/app/libmain.cxx:521 #20 0x55c88c27827c in rpmostreecxx::rpmostree_main(rust::cxxbridge1::Slice<rust::cxxbridge1::Str const>) src/app/libmain.cxx:546 #21 0x55c88c271c25 in operator() /var/srv/walters/src/github/coreos/rpm-ostree/rpmostree-cxxrs.cxx:1257 #22 0x55c88c271c25 in trycatch<rpmostreecxx::rpmostreecxx$cxxbridge1$rpmostree_main(rust::cxxbridge1::Slice<const rust::cxxbridge1::Str>)::<lambda()>, rpmostreecxx::rpmostreecxx$cxxbridge1$rpmostree_main(rust::cxxbridge1::Slice<const rust::cxxbridge1::Str>)::<lambda(char const*)> > /var/srv/walters/src/github/coreos/rpm-ostree/rpmostree-cxxrs.cxx:997 #23 0x55c88c271c25 in rpmostreecxx$cxxbridge1$rpmostree_main /var/srv/walters/src/github/coreos/rpm-ostree/rpmostree-cxxrs.cxx:1255 #24 0x55c88c0468f7 in rpmostree_rust::ffi::rpmostree_main::hfedda48c684245ce rust/src/lib.rs:25 #25 0x55c88c0468f7 in rpm_ostree::inner_main::hf078b99ca4b270aa rust/src/main.rs:9 #26 0x55c88c0468f7 in rpm_ostree::main::hc0ca527cfaa3f556 rust/src/main.rs:28 #27 0x55c88c046b22 in core::ops::function::FnOnce::call_once::h8567110dac55274e /var/home/walters/.rustup/toolchains/1.48-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:227 #28 0x55c88c046b22 in std::sys_common::backtrace::__rust_begin_short_backtrace::h1c67f2f52d05cfa0 /var/home/walters/.rustup/toolchains/1.48-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys_common/backtrace.rs:137 #29 0x55c88c045fd7 in main (/usr/bin/rpm-ostree+0xc9fd7) #30 0x7f92076091e1 in __libc_start_main (/lib64/libc.so.6+0x281e1) #31 0x55c88c045b9d in _start (/usr/bin/rpm-ostree+0xc9b9d) Address 0x7ffc290d9440 is located in stack of thread T0 at offset 272 in frame #0 0x55c88c31a1af in rpmostree_run_script_in_bwrap_container src/libpriv/rpmostree-scripts.cxx:349 ```

cgwalters added a commit that referenced this issue Sep 30, 2014

tests: Add a rebase test

d8e6bd8

This crashes for me sometimes, so let's add a test. #30

cgwalters added a commit to ostreedev/ostree that referenced this issue Sep 30, 2014

upgrader: Hold a ref to the origin

1b8759a

We unref it in _finalize, so we need to hold a ref. I *thought* this was the source of coreos/rpm-ostree#30 But apparently not =/

cgwalters closed this as completed Sep 30, 2014

cgwalters mentioned this issue Sep 21, 2017

ci: Sync with ostree #1000

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

crash at end of rebase #30

crash at end of rebase #30

cgwalters commented Sep 25, 2014

cgwalters commented Sep 30, 2014

crash at end of rebase #30

crash at end of rebase #30

Comments

cgwalters commented Sep 25, 2014

cgwalters commented Sep 30, 2014