Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override replace --freeze --from chooses older packages #4037

Closed
cgwalters opened this issue Sep 23, 2022 · 0 comments · Fixed by #4062
Closed

override replace --freeze --from chooses older packages #4037

cgwalters opened this issue Sep 23, 2022 · 0 comments · Fixed by #4062

Comments

@cgwalters
Copy link
Member

See openshift/okd-machine-os#441 (comment)

Here we're adding the coreos-continuous copr, but for some reason we're downloading a very old package.

I was initially trying to debug this in rpmostree-core.cxx - I'd been looking at the repo override path there. But what's actually going on is we have a whole other special case path in rpmostree_find_and_download_packages().

I am increasingly of the opinion that we need to pare down this technical debt and really do a deep push towards a layering model for customization, and keep the client stuff simple.
cgwalters added a commit to cgwalters/okd-machine-os that referenced this issue Sep 23, 2022
@cgwalters
Use ex rebuild to pull from COPR
e49e45d 
This works around coreos/rpm-ostree#4037
@cgwalters cgwalters mentioned this issue Sep 23, 2022
Merged
cgwalters added a commit to cgwalters/okd-machine-os that referenced this issue Sep 23, 2022
@cgwalters
Use ex rebuild to pull from COPR
71a954c 
This works around coreos/rpm-ostree#4037
cgwalters added a commit to cgwalters/okd-machine-os that referenced this issue Sep 23, 2022
@cgwalters
Use ex rebuild to pull from COPR
2eb99d7 
This works around coreos/rpm-ostree#4037
cgwalters added a commit to cgwalters/okd-machine-os that referenced this issue Sep 23, 2022
@cgwalters
Use ex rebuild to pull from COPR
196f83f 
This works around coreos/rpm-ostree#4037
cgwalters added a commit to cgwalters/okd-machine-os that referenced this issue Sep 23, 2022
@cgwalters
Use ex rebuild to pull from COPR
4c03e8e 
This works around coreos/rpm-ostree#4037
jlebon added a commit to jlebon/rpm-ostree that referenced this issue Sep 28, 2022
@jlebon
core: Filter for latest when downloading packages
8877d78 
The tightly-scoped function `rpmostree_find_and_download_packages`
function just takes a query and returns fds to downloaded packages. It
does not do any depsolving, so it's up to us to select the exact
package we want to download. This means explicitly telling libdnf we
want the latest version. This matches e.g. `dnf download`.

Closes: coreos#4037
@jlebon jlebon mentioned this issue Sep 28, 2022
Merged
cgwalters pushed a commit that referenced this issue Sep 28, 2022
@jlebon @cgwalters
core: Filter for latest when downloading packages
88e5904 
The tightly-scoped function `rpmostree_find_and_download_packages`
function just takes a query and returns fds to downloaded packages. It
does not do any depsolving, so it's up to us to select the exact
package we want to download. This means explicitly telling libdnf we
want the latest version. This matches e.g. `dnf download`.

Closes: #4037
vrutkovs pushed a commit to vrutkovs/okd-machine-os that referenced this issue Nov 9, 2022
@cgwalters @vrutkovs
Use ex rebuild to pull from COPR
f21359e 
This works around coreos/rpm-ostree#4037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: Filter for latest when downloading packages jlebon/rpm-ostree
1 participant
@cgwalters