Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic container configuration #4701

Closed
cgwalters opened this issue Nov 27, 2023 · 2 comments · Fixed by #4703
Closed

Add generic container configuration #4701

cgwalters opened this issue Nov 27, 2023 · 2 comments · Fixed by #4703
Labels
area/baseimage-builds container-native

Comments

@cgwalters
Copy link
Member

Today we have basic support for container-cmd to be the equivalent of the CMD containerfile instruction. We should support everything in the spec (xref config spec and Rust API).

I think probably the simplest is to support deserializing the Rust struct literally inside a treefile, like:
container_config: Option<oci_spec::image::Config>.
cgwalters added a commit to cgwalters/ostree-rs-ext that referenced this issue Nov 28, 2023
@cgwalters
encapsulate: Support setting arbitrary container config
1c8fa1e 
Part of coreos/rpm-ostree#4701

Basically we should support setting arbitrary container configuration.
@cgwalters cgwalters mentioned this issue Nov 28, 2023
Merged
@cgwalters
Copy link
Member Author

Did ostreedev/ostree-rs-ext#567

cgwalters added a commit to cgwalters/rpm-ostree that referenced this issue Nov 28, 2023
@cgwalters
compose: Add support for specifying image config
a60e07f 
This adds generic support for specifying image configuration.

Closes: coreos#4701
@cgwalters cgwalters mentioned this issue Nov 28, 2023
Merged
@cgwalters
Copy link
Member Author

PR in #4703

@jmarrero jmarrero mentioned this issue Nov 29, 2023
Merged
@travier travier mentioned this issue Nov 30, 2023
Closed
@cgwalters cgwalters mentioned this issue Jan 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/baseimage-builds container-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lib: Update ostree-ext && compose: Add support for specifying image config cgwalters/rpm-ostree
1 participant
@cgwalters