Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON output to update --check and include the version of the target container image for the Ostree Native Container path #4711

Closed
travier opened this issue Nov 30, 2023 · 0 comments · Fixed by #4923 or #4936

Comments

@travier
Copy link
Member

travier commented Nov 30, 2023

To be able to more easily use the output of rpm-ostree update --check in Plasma Discover, add JSON output to update --check and include the version of the target container image for the Ostree Native Container path, similarly to how it is displayed in the classic ostree path.

Host system details

Latest rpm-ostree.

Expected behavior

# rpm-ostree update --check
...
Available update: Version: .....
Layers:
...

# rpm-ostree update --check --json
{
    "origin": "ostree-unverified-image:registry:quay.io/foo/bar/latest"
    "version": "40.X.Y",
    "layers": {
        "total": {
            "count": "",
            "size": "" 
        },
        "removed": {
            "count": "",
            "size": "" 
        },
        "added": {
            "count": "",
            "size": "" 
        },
    }
}

# or when no new version is found:
# rpm-ostree update --check --json
{}

Steps to reproduce it

Check for updates on a system using Ostree Native Container.

Would you like to work on the issue?

Yes, will start working on this.

@travier travier self-assigned this Nov 30, 2023
travier added a commit to travier/rpm-ostree that referenced this issue Apr 16, 2024
Adding JSON output to `update --check` will make it easier to use the
output of `rpm-ostree update --check` in Plasma Discover when updating
using Ostree Native Containers.

Fixes: coreos#4711
travier added a commit to travier/rpm-ostree that referenced this issue Apr 16, 2024
Adding JSON output to `update --check` will make it easier to use the
output of `rpm-ostree update --check` in Plasma Discover when updating
using Ostree Native Containers.

Fixes: coreos#4711
travier added a commit to travier/rpm-ostree that referenced this issue Apr 16, 2024
Adding JSON output to `update --check` will make it easier to use the
output of `rpm-ostree update --check` in Plasma Discover when updating
using Ostree Native Containers.

Fixes: coreos#4711
travier added a commit to travier/rpm-ostree that referenced this issue Apr 17, 2024
Adding JSON output to `update --check` will make it easier to use the
output of `rpm-ostree update --check` in Plasma Discover when updating
using Ostree Native Containers.

Fixes: coreos#4711
travier added a commit to travier/rpm-ostree that referenced this issue Apr 17, 2024
Adding JSON output to `update --check` will make it easier to use the
output of `rpm-ostree update --check` in Plasma Discover when updating
using Ostree Native Containers.

Fixes: coreos#4711
travier added a commit to travier/rpm-ostree that referenced this issue Apr 19, 2024
Adding the version of the cached update to `rpm-ostree status --json`
output will make it easier to use it for update checks in Plasma
Discover when updating using Ostree Native Containers.

Fixes: coreos#4711
travier added a commit to travier/rpm-ostree that referenced this issue Apr 22, 2024
Previous change used the version of the current deployment instead of
the one from the pending container update.

Store the new version alongside the manifest diff to be able to return
it as part of the cached update logic.

Fixes: coreos#4923
Fixes: coreos#4711
travier added a commit to travier/rpm-ostree that referenced this issue Apr 22, 2024
Previous change used the version of the current deployment instead of
the one from the pending container update.

Store the new version alongside the manifest diff to be able to return
it as part of the cached update logic.

Fixes: coreos#4923
Fixes: coreos#4711
lukewarmtemp pushed a commit to lukewarmtemp/rpm-ostree that referenced this issue Apr 23, 2024
Adding the version of the cached update to `rpm-ostree status --json`
output will make it easier to use it for update checks in Plasma
Discover when updating using Ostree Native Containers.

Fixes: coreos#4711
lukewarmtemp pushed a commit to lukewarmtemp/rpm-ostree that referenced this issue Apr 24, 2024
Previous change used the version of the current deployment instead of
the one from the pending container update.

Store the new version alongside the manifest diff to be able to return
it as part of the cached update logic.

Fixes: coreos#4923
Fixes: coreos#4711
lukewarmtemp pushed a commit to lukewarmtemp/rpm-ostree that referenced this issue Apr 24, 2024
Previous change used the version of the current deployment instead of
the one from the pending container update.

Store the new version alongside the manifest diff to be able to return
it as part of the cached update logic.

Fixes: coreos#4923
Fixes: coreos#4711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant