dbus api to change kernel arguments #594

cgwalters · 2017-01-27T15:30:14Z

This would abstract things a bit, be more reliable since we'd do atomic swaps rather than having admins do vi or something on /boot/loader/entries/ostree-fedora-0.conf etc.

$ rpm-ostree kernel-args 
rd.lvm.lv=fw/root rhgb quiet root=/dev/mapper/fw-root
$ rpm-ostree kernel-args --append foo=bar baz=whee
$ rpm-ostree kernel-args --delete foo

The text was updated successfully, but these errors were encountered:

vtolstov · 2017-01-27T19:04:09Z

2017-01-27 18:30 GMT+03:00 Colin Walters <notifications@github.com>:

This would abstract things a bit, be more reliable since we'd do atomic swaps rather than having admins do vi or something on /boot/loader/entries/ostree-fedora-0.conf etc. $ rpm-ostree kernel-args rd.lvm.lv=fw/root rhgb quiet root=/dev/mapper/fw-root $ rpm-ostree kernel-args --append foo=bar baz=whee $ rpm-ostree kernel-args --delete foo

Nice feature, in which cases and how ostree/rpm-ostree use this entries? If i modify it via vi, does rpm-ostree upgrade use this options when generate grub conf?

…

-- Vasiliy Tolstov, e-mail: v.tolstov@selfip.ru

cgwalters · 2017-02-23T17:27:53Z

If anyone wants to edit kernel arguments on an rpm-ostree managed system today, you need to:

vi /boot/loader/entries/ostree-*-0.conf

Then if using GRUB2 (most Fedora/CentOS architectures):

If EFI:

grub2-mkconfig > /boot/efi/EFI/fedora/grub.cfg.new && mv /boot/efi/EFI/fedora/grub.cfg{.new,}

If BIOS:

grub2-mkconfig > /boot/loader/grub.cfg.new && mv /boot/loader/grub.cfg{.new,}

canit00 · 2017-02-23T22:29:37Z

thank you @cgwalters for providing these steps.

However, I get the following error:

grub2-mkconfig /boot/loader/grub.cfg.new
Generating grub configuration file ...
/etc/grub.d/10_devmode+: line 28: _OSTREE_GRUB2_BOOTVERSION: unbound variable

Our goal is to disable IPv6 on all of our Atomic hosts running containerized OpenShift. Unfortunately, disabling this through NetworkManager or in /etc/sysctl.d/ does not appear to be working.

The root of this want leads back to our IPF routers consistently going down and want to get rid of the vast log entries for IPv6.

This is what I see when issuing ip -a that leads me to believe that IPv6 isn't disabled.

12: veth6493a05c@if3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1450 qdisc noqueue master ovs-system state UP
link/ether 46:0e:05:48:4f:2e brd ff:ff:ff:ff:ff:ff link-netnsid 1
inet6 fe80::3a9b:9270:66da:69de/64 scope link
valid_lft forever preferred_lft forever

grub2_issue.pdf

Is this the right place to post this?

Sincerely,
SA

jlebon · 2017-02-24T14:35:39Z

This used to be an issue in older ostrees. Try:

	bootver=$(readlink /boot/loader)
	_OSTREE_GRUB2_BOOTVERSION=${bootver#*.} \
          grub2-mkconfig -o /boot/loader/grub.cfg

ostreedev/ostree#165
https://github.com/projectatomic/atomic-devmode/blob/master/libexec/bootentry#L45

Our hook was breaking the workflow for people who manually wanted to call grub2-mkconfig because we expected _OSTREE_GRUB2_BOOTVERSION to always be available. See e.g.: coreos/rpm-ostree#594 Instead, we should use the same logic as `ostree admin instutil grub2-generate`: target _OSTREE_GRUB2_BOOTVERSION if available, otherwise, just target the current bootversion.

jlebon · 2017-02-27T15:53:35Z

Actually, I misremembered and got confused up above.

However, I get the following error:

grub2-mkconfig /boot/loader/grub.cfg.new
Generating grub configuration file ...
/etc/grub.d/10_devmode+: line 28: _OSTREE_GRUB2_BOOTVERSION: unbound variable

This isn't the same ostree bug, but a different atomic-devmode one. Should be fixed by projectatomic/atomic-devmode#9. You'll have to use the workaround above in the meantime though (or alternatively, if you have no use for the Developer Mode feature, you can disable it with /usr/libexec/atomic-devmode/bootentry remove).

Our hook was breaking the workflow for people who manually wanted to call grub2-mkconfig because we expected _OSTREE_GRUB2_BOOTVERSION to always be available. See e.g.: coreos/rpm-ostree#594 Instead, we should use the same logic as `ostree admin instutil grub2-generate`: target _OSTREE_GRUB2_BOOTVERSION if available, otherwise, just target the current bootversion.

cgwalters · 2017-08-15T17:14:52Z

See also https://mail.gnome.org/archives/ostree-list/2017-July/msg00002.html

peterbaouoft · 2017-09-05T18:23:37Z

Hi, For implementation of the kernel-args command, I have a few doubts. It will be great if you have time to answer them :).
1: What functionality do we want to implement with kernel-args command, do we want to share a similar functionality as ostree admin instutil set-kargs ? ( with the addition of --delete functionality)

2: due to the similarity of these two commands, do we want to possibly use some of the functions that are already developed in ostree?

3: Do we need to worry about the grub related issues after users modify the conf file?

cgwalters · 2017-09-07T14:01:27Z

Based on discussion, I think it'd say:

Let's do this in rpm-ostree kargs first; we can fix ostree later.

Most of the API that lives in libostree today should be enough - if not, let's extend the ostree API?

As far as point 3) - let's not worry about it for now, this will fix itself if we eventually do ostreedev/ostree#717

cgwalters · 2017-09-07T14:02:26Z

I just made this up but I think it'd be cool if rpm-ostree kargs --edit popped up $EDITOR and allowed you to make arbitrary changes. We have some code for that in ostree commit.

peterbaouoft · 2017-09-14T13:50:18Z

(5) dbus api to change kernel arguments

This is initial groundwork for coreos#594. This commit sets up most of the required front end logic( arg parsing, transaction handling), and will be used in the following commits. There is nothing really fancy in this commit, as most of the code shares the similar style between other dbus related commands.

This is initial groundwork for #594. This commit sets up most of the required front end logic( arg parsing, transaction handling), and will be used in the following commits. There is nothing really fancy in this commit, as most of the code shares the similar style between other dbus related commands. Closes: #1013 Approved by: cgwalters

jlebon · 2018-04-30T15:03:57Z

Done in #1013.

cgwalters added the kind/enhancement label Jan 28, 2017

cgwalters mentioned this issue Jun 19, 2017

Add polkit 🔒 support #825

Closed

cgwalters mentioned this issue Jul 17, 2017

grub2-mkconfig when invoked directly generates bad config on EFI ostreedev/ostree#1009

Closed

peterbaouoft mentioned this issue Sep 26, 2017

rpm-ostree kargs command #1013

Closed

jlebon closed this as completed Apr 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dbus api to change kernel arguments #594

dbus api to change kernel arguments #594

cgwalters commented Jan 27, 2017

vtolstov commented Jan 27, 2017 via email

cgwalters commented Feb 23, 2017

canit00 commented Feb 23, 2017

jlebon commented Feb 24, 2017

jlebon commented Feb 27, 2017 •

edited

Loading

cgwalters commented Aug 15, 2017

peterbaouoft commented Sep 5, 2017

cgwalters commented Sep 7, 2017

cgwalters commented Sep 7, 2017

peterbaouoft commented Sep 14, 2017

jlebon commented Apr 30, 2018

dbus api to change kernel arguments #594

dbus api to change kernel arguments #594

Comments

cgwalters commented Jan 27, 2017

vtolstov commented Jan 27, 2017 via email

cgwalters commented Feb 23, 2017

canit00 commented Feb 23, 2017

jlebon commented Feb 24, 2017

jlebon commented Feb 27, 2017 • edited Loading

cgwalters commented Aug 15, 2017

peterbaouoft commented Sep 5, 2017

cgwalters commented Sep 7, 2017

cgwalters commented Sep 7, 2017

peterbaouoft commented Sep 14, 2017

jlebon commented Apr 30, 2018

jlebon commented Feb 27, 2017 •

edited

Loading