Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support copying passwd data from previous commit #78

Closed
cgwalters opened this issue Dec 22, 2014 · 1 comment · Fixed by #79
Closed

Support copying passwd data from previous commit #78

cgwalters opened this issue Dec 22, 2014 · 1 comment · Fixed by #79

Comments

@cgwalters
Copy link
Member

The checking code from #56 landed, and started triggering for me on the dockerroot user. It's nice to know it works. Then the issue is... "what now"?

It turns out in the case of dockerroot it's actually unused, so we could fix this by deleting it. But in general we need to support dynamic uids/gids/. And we can't yet take a hard dep on #49.

So here's an idea: why don't we just (optionally, but probably by default) take a copy of the passwd/group data from the previous commit? We would merge the data from the altfiles split into /etc before doing any package operations at all.

cgwalters added a commit to cgwalters/rpm-ostree that referenced this issue Dec 23, 2014
The checking code from #56 landed, and started triggering for me on
the `dockerroot` user. It's nice to know it works. Then the issue
is... "what now"?

It turns out in the case of `dockerroot` it's actually unused, so we
could fix this by deleting it. But in general we need to support
dynamic uids/gids/. And we can't yet take a hard dep on #49.

So this patch changes things so we take a copy of the passwd/group
data from the previous commit.  Any users subsequently added in the
*new* commit will be additive.

Closes: coreos#78
@cgwalters
Copy link
Member Author

This was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant