Pr/config ctx from depl #1038
Closed
Pr/config ctx from depl #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function in the core that knows how to take a deployment and point its passwd dir and libdnf's repos dir to it. We call it the "configuration deployment", because those are configuration files which should be inherited from the config merge, not the origin merge. Prep for `makecache`.
Let callers pass `NULL` for the `@spec` argument. This essentially means that they're not interested in actually doing any installation/commit operations, but just the semantics that the core uses when setting up libdnf wrt e.g. install and source root and enabled repos = required, etc... Prep for `makecache`.
cgwalters
reviewed
Oct 5, 2017
|
|
||
| /* point libhif to the yum.repos.d and os-release of the merge deployment */ | ||
| dnf_context_set_repo_dir (hifctx, reposdir); | ||
| dnf_context_set_source_root (hifctx, tmprootfs); |
There was a problem hiding this comment.
We're no longer calling _set_source_root()...is that intentional?
There was a problem hiding this comment.
Yeah, it basically got overridden anyway by the set_source_root() at rpmostree_context_setup time. I think this precedes that functionality being added directly in rpmostree_context_setup.
There was a problem hiding this comment.
I don't mind splitting this as a separate commit if you'd prefer!
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Oct 5, 2017
Let callers pass `NULL` for the `@spec` argument. This essentially means that they're not interested in actually doing any installation/commit operations, but just the semantics that the core uses when setting up libdnf wrt e.g. install and source root and enabled repos = required, etc... Prep for `makecache`. Closes: #1038 Approved by: cgwalters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor prep for #1035.