app/dbus-helpers: Return early if no diff to print #1431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new update might not have any package changes at all. In which case, we shouldn't even try to print the diff, otherwise we'll fail on trying to lookup the `upgraded` key. We did this check already from `rpmostree_print_cached_update`, but not from `print_one_deployment` (when printing the diff as part of the pending deployment), so we'd error out on no-diff upgrades. Let's just inline a check in the function directly instead of wrapping every call site.
|
Looks sane to me. Oooh, the CI failures are fallout from ostreedev/ostree#1654 |
|
@rh-atomic-bot r=cgwalters 49ef988 |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new update might not have any package changes at all. In which case,
we shouldn't even try to print the diff, otherwise we'll fail on trying
to lookup the
upgradedkey. We did this check already fromrpmostree_print_cached_update, but not fromprint_one_deployment(when printing the diff as part of the pending deployment), so we'd
error out on no-diff upgrades.
Let's just inline a check in the function directly instead of wrapping
every call site.