Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2018.10 #1713

Closed
wants to merge 2 commits into from
Closed

Release 2018.10 #1713

wants to merge 2 commits into from

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Dec 12, 2018

It's been a while and we have lots of goodies. Likely the last one
before the new year. 🎉

@cgwalters
Copy link
Member

@rh-atomic-bot r+ b3c77d8

@rh-atomic-bot
Copy link

⌛ Testing commit b3c77d8 with merge ec7ab49...

rh-atomic-bot pushed a commit that referenced this pull request Dec 12, 2018
It's been a while and we have lots of goodies. Likely the last one
before the new year. 🎉

Closes: #1713
Approved by: cgwalters
@rh-atomic-bot
Copy link

💔 Test failed - status-atomicjenkins

The latest backtrace release isn't compatible with 1.26.2. A patch for
this is underway in:

rust-lang/backtrace-rs#137

Though for now, let's just restrict the version since we should be
bumping our minimum rustc requirement soon-ish anyway.
It's been a while and we have lots of goodies. Likely the last one
before the new year. 🎉
@jlebon
Copy link
Member Author

jlebon commented Dec 13, 2018

OK, we were getting compilation errors in the backtrace crate against 1.26.2. I fixed the version of the crate back to the last working version for now. ⬆️

@jlebon
Copy link
Member Author

jlebon commented Dec 13, 2018

This is good to go now!

@cgwalters
Copy link
Member

@rh-atomic-bot r+ bb0cdd9

@rh-atomic-bot
Copy link

⚡ Test exempted: pull fully rebased and already tested.

rh-atomic-bot pushed a commit that referenced this pull request Dec 13, 2018
It's been a while and we have lots of goodies. Likely the last one
before the new year. 🎉

Closes: #1713
Approved by: cgwalters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants