Updates to vagrant docs + workflow #1826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
May 2, 2019
Add a link to tests/README.md to point readers to additional information on where to find different types of tests.
Switch the Docker + Vagrant development docs to use a Fedora 29 build container, and a Fedora 29 Atomic Host Vagrant box. CentOS 7-based testing was recently removed (coreos#1785) - let's have the documented development pattern reflect this. Also no longer enables the EPEL7 repo in the Vagrant VM, as needed dependencies are available in Fedora Atomic Host. A note is left to later switch to Fedora CoreOS as the documented Vagrant box to use, once Fedora CoreOS boxes are produced. Alternatively, one may use [cosa](https://github.com/coreos/coreos-assembler). A few notes are also added to vagrant/README.md in places where the reader may hit problems. squash
rfairley
force-pushed
the
rfairley-vagrant-doc-update
branch
from
97169db
to
b986612
Compare
|
This looks sane to me, but will surely change more soon; I definitely want to push the cosa dev path. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 9, 2019
Switch the Docker + Vagrant development docs to use a Fedora 29 build container, and a Fedora 29 Atomic Host Vagrant box. CentOS 7-based testing was recently removed (#1785) - let's have the documented development pattern reflect this. Also no longer enables the EPEL7 repo in the Vagrant VM, as needed dependencies are available in Fedora Atomic Host. A note is left to later switch to Fedora CoreOS as the documented Vagrant box to use, once Fedora CoreOS boxes are produced. Alternatively, one may use [cosa](https://github.com/coreos/coreos-assembler). A few notes are also added to vagrant/README.md in places where the reader may hit problems. squash Closes: #1826 Approved by: cgwalters
|
☀️ Test successful - status-atomicjenkins |
rfairley
pushed a commit
to rfairley/rpm-ostree
that referenced
this pull request
May 9, 2019
Follow-up to coreos#1826 to reflect new development occuring for Fedora CoreOS using coreos-assembler.
rfairley
pushed a commit
to rfairley/rpm-ostree
that referenced
this pull request
May 9, 2019
Follow-up to coreos#1826 to reflect new development occurring for Fedora CoreOS using coreos-assembler.
dustymabe
reviewed
May 14, 2019
| @@ -4,10 +4,10 @@ | |||
|
|
|||
| Vagrant.configure(2) do |config| | |||
|
|
|||
| config.vm.box = "centosah/7alpha" | |||
| config.vm.box_url = 'https://ci.centos.org/artifacts/sig-atomic/centos-continuous/images-alpha/cloud/latest/images/centos-atomic-host-7-vagrant-libvirt.box' | |||
| # TODO: switch to the Fedora 30 CoreOS vagrant box once available | |||
There was a problem hiding this comment.
f30 vagrant box is available now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I've been using the container/VM workflow recently - floating this as an update. I wonder if we'd later want to document using toolbox for the container or mention a coreos-assembler-based workflow - but for now just keeping it general with an F29 image.
Also add a few pointers to the README on issues I hit when first doing this.