Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmcheck: Work around read-only /sysroot #2023

Merged
merged 2 commits into from
Mar 19, 2020
Merged

vmcheck: Work around read-only /sysroot #2023

merged 2 commits into from
Mar 19, 2020

Commits on Mar 19, 2020

  1. vmcheck: Run vm_kola_spawn separately from if-statement 

    Classic shell gotcha. We don't want to run `vm_kola_spawn` as part of
the if-statement or otherwise we lose the `set -e` behaviour.
    @jlebon
    jlebon committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    e521b50 View commit details
    Browse the repository at this point in the history

  2. vmcheck: Work around read-only /sysroot 

    We need to adapt some of our tests here which assume that `/sysroot` is
writable. However, in FCOS this is no longer the case now that we enable
`sysroot.readonly`.

We only remount rw for the couple of operations that need it so that we
still retain coverage for the ro path everywhere else.
    @jlebon
    jlebon committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    55206db View commit details
    Browse the repository at this point in the history