Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make /run a directory in scripts #2275

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Make /run a directory in scripts #2275

merged 1 commit into from
Oct 22, 2020

Conversation

cgwalters
Copy link
Member

It's part of the expected standard environment, and its omission
ended up breaking some bootupd work.
See coreos/bootupd#84 (comment)

@cgwalters cgwalters mentioned this pull request Oct 20, 2020
Merged
jlebon
jlebon approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing equivalent change in bwrap-script-shell.sh. LGTM otherwise!

@ashcrow
Copy link
Member

ashcrow commented Oct 20, 2020

CI looks like it passed by the output but shows failure. Flake?

@jlebon
Copy link
Member

jlebon commented Oct 20, 2020

Yeah, you have to look at the console logs from the classic Jenkins interface.

FAIL: rojig-e2e
   rojig-e2e: d6a26fa6829ba054cce97598af32e4c5aea4abba8e898b8164f885d79b009073
   rojig-e2e: ++ date
   rojig-e2e: + echo 'Tue Oct 20 19:23:17 UTC 2020: starting fsck'
   rojig-e2e: Tue Oct 20 19:23:17 UTC 2020: starting fsck
   rojig-e2e: + ostree --repo=rojig-unpack-repo fsck
   rojig-e2e: Validating refs...
   rojig-e2e: Validating refs in collections...
   rojig-e2e: Enumerating objects...
   rojig-e2e: Verifying content integrity of 379 commit objects...
   rojig-e2e: fsck objects (1/29665) 0%
   rojig-e2e: fsck objects (4758/29665) 16%
   rojig-e2e: fsck objects (8420/29665) 28%
   rojig-e2e: Object missing in commits d6a26fa6829ba054cce97598af32e4c5aea4abba8e898b8164f885d79b009073: 2f403897802813b25c7fd409afdc5aaa2aa94820bb04dda76524289ebda544db.file
   rojig-e2e: Marking commit as partial: d6a26fa6829ba054cce97598af32e4c5aea4abba8e898b8164f885d79b009073
   rojig-e2e: fsck objects (13880/29665) 46%
   rojig-e2e: fsck objects (16343/29665) 55%
   rojig-e2e: fsck objects (19218/29665) 64%
   rojig-e2e: fsck objects (24709/29665) 83%
   rojig-e2e: fsck objects (29665/29665) 100%
   rojig-e2e: error: Repository corruption encountered

Hmm, that's slightly worrying though doubt it's related to this change. Let's keep an eye out for it.

@cgwalters
Copy link
Member Author

OK going to dig into the rojig-e2e a bit...it's probably a bug in rojig but it's odd that it just started happening now.

@jlebon
Copy link
Member

jlebon commented Oct 22, 2020

OK going to dig into the rojig-e2e a bit...it's probably a bug in rojig but it's odd that it just started happening now.

Maybe related to the bump to f32? (See 230a0ea)

@cgwalters
Make /run a directory in scripts
692b47a 
It's part of the expected standard environment, and its omission
ended up breaking some bootupd work.
See coreos/bootupd#84 (comment)
@jlebon
Copy link
Member

jlebon commented Oct 22, 2020

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1b40810 into coreos:master Oct 22, 2020
cgwalters added a commit to cgwalters/fedora-coreos-config that referenced this pull request Oct 23, 2020
@cgwalters
manifests/bootupd: mkdir /run for now
9630374 
This is a quick backport of coreos/rpm-ostree#2275
effectively, so we can proceed with fixing bootupd.
@cgwalters cgwalters mentioned this pull request Oct 23, 2020
Merged
jlebon pushed a commit to coreos/fedora-coreos-config that referenced this pull request Oct 23, 2020
@cgwalters @jlebon
manifests/bootupd: mkdir /run for now
cb30080 
This is a quick backport of coreos/rpm-ostree#2275
effectively, so we can proceed with fixing bootupd.
kelvinfan001 pushed a commit to kelvinfan001/fedora-coreos-config that referenced this pull request Dec 14, 2020
@cgwalters @kelvinfan001
manifests/bootupd: mkdir /run for now
a2beeb4 
This is a quick backport of coreos/rpm-ostree#2275
effectively, so we can proceed with fixing bootupd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

@ashcrow ashcrow Awaiting requested review from ashcrow

Assignees

@jlebon jlebon

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cgwalters @ashcrow @jlebon @openshift-ci-robot @openshift-merge-robot