compose extensions: Support --rootfs
#3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
cgwalters
force-pushed
the
compose-extensions-incontainer
branch
3 times, most recently
from
5b0cd96
to
cec7714
Compare
|
/test all |
|
To test this I did: (Where |
cgwalters
force-pushed
the
compose-extensions-incontainer
branch
from
cec7714
to
5261409
Compare
|
OK, this should now work in both cases. |
As we're working on "container native" (rpm)-ostree, it feels natural to have the extensions build happen as part of e.g. a `Dockerfile` build that simply pulls in the base image. And to do that, we don't need any of this "offline" stuff that the compose extensions path is using. Here we're running rpm-ostree inside a container, and conceptually we mostly just need the libdnf side.
cgwalters
force-pushed
the
compose-extensions-incontainer
branch
from
5261409
to
9e4d3da
Compare
|
@cgwalters Thank you for this. LGTM |
jmarrero
approved these changes
Mar 28, 2022
jlebon
approved these changes
Mar 28, 2022
| @@ -1469,11 +1472,6 @@ rpmostree_compose_builtin_extensions (int argc, char **argv, RpmOstreeCommandInv | |||
| rpmostree_usage_error (context, "TREEFILE and EXTYAML must be specified", error); | |||
| return FALSE; | |||
| } | |||
| if (!opt_repo) | |||
There was a problem hiding this comment.
Instead of dropping this, should we enhance it to verify that one and only one of --repo and --rootfs is provided?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're working on "container native" (rpm)-ostree, it feels
natural to have the extensions build happen as part of e.g. a
Dockerfilebuild that simply pulls in the base image.And to do that, we don't need any of this "offline" stuff that
the compose extensions path is using. Here we're running
rpm-ostree inside a container, and conceptually we mostly just
need the libdnf side.