Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compose: Use GVariantDict, not manual hash table #3760

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

compose: Use GVariantDict, not manual hash table #3760

wants to merge 1 commit into from

Commits on Jun 10, 2022

  1. compose: Use GVariantDict, not manual hash table 

    There's a dedicated type for a mapping from "string to variant" in
`GVariantDict`.  Use it instead of rolling our own with `GHashTable`.
The advantage here is improved ergonomics from the C side; e.g.
we can directly pass C strings for values and have the variant
allocated internally.

But more importantly, this is prep for oxidizing things here because
we can pass `GVariantDict` to/from Rust easily, not so with
`GHashTable`.
    @cgwalters
    cgwalters committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    f89f5cd View commit details
    Browse the repository at this point in the history