-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2022.10 #3763
Merged
Merged
Release 2022.10 #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhhh 😕 |
jlebon
previously approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failure looks unrelated. Looks like git main
is failing with that too now.
Humm...what could have snuck through CI like this? I did
|
cgwalters
added a commit
to cgwalters/cxx
that referenced
this pull request
Jun 13, 2022
For some reason I don't yet fully understand, the build of rpm-ostree started failing with a panic in `cxxbridge`: coreos/rpm-ostree#3763 (comment) What I haven't worked out is what changed to break this; my best guess is something like compiler type inference? AFAICS, the code here hasn't changed in a long time, and neither has the lockfiles. (Hmm...unless we're not using lockfiles for this...ah yes, that would explain it. And https://crates.io/crates/clap/3.2.1 was just published. Will dig into this more) Anyways, this is not an elegant fix; we just (correctly) ask clap to give us `OsString` and not `String`. The real fix is clearly to stop using all the deprecated clap APIs, but I'm trying to make the least invasive change for the moment.
cgwalters
force-pushed
the
release-2022-10
branch
from
June 13, 2022 21:49
7c6f166
to
9060ec6
Compare
OK rebased 🏄 |
jlebon
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes draft: https://hackmd.io/fQG88NY5RqaDDZRcZh_wdQ