-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using prior builds for improving encapsulation #4271
Conversation
Skipping CI for Draft Pull Request. |
332c969
to
353a7da
Compare
be10f1e
to
13ff8cc
Compare
We also need to tackle the case where we need to supply What would be a better way to supply the metadata to |
I think we can stash this file in the temporary directory allocated in rpm-ostree/rust/src/compose.rs Line 144 in f525121
|
c8345e8
to
874d395
Compare
6901fae
to
3bb2853
Compare
1bd612f
to
1f5d758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
Looks like this needs a rebase now? |
This actually needed another rebase after #4422 I also reworked the two commits such that all the changes related to bumping ostree-ext were in the prior commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think this is good to land! There's clearly some followup we will want to do but I think we can iterate on that after merging.
Blah, I shouldn't have merged that dependabot clap rebase, it conflicted. Rebased this on that anyways though. |
- ostree-ext updates to new ostree, so adjust our usage of the ostree crate - Also adjust for changed ostree-ext APIs - ostree-ext now re-exports cap-std-ext 2.0, which stopped re-exporting rustix, so depend on that directly
Prune rpm changelogs of packages to within the last year and use it as frequency of update for the rpm.
OK needed a small tweak for the usage test due to the clap change. Not sure what's going wrong though in the container failure, might just be the same timeout as other jobs though. |
Not sure why the destructive tests are failing |
Not sure yet either...as far as I can tell, we seem to be failing to reboot? |
OK so I debugged this using
(Should probably make this something like Anyways the problem is the automatic upgrade trigger is failing:
(So we don't reboot, hence hang) And I think that is fallout from Which...perhaps arguably is actually a good thing. Hmm. |
This no longer works since ostreedev/ostree-rs-ext@f450812 Which is actually a good thing. I'll look at readding this test in another place.
OK, pushed a change that should fix this. |
Fixes: #4247
To do: