Make output handling thread-local #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because for transactions (which are always run in a thread today) we want output to go to the transaction's DBus progress. But for other methods which are not transactions, we don't have a channel for status reporting, so output needs to continue to go to the journal. If we mix these two things due to concurrent method invocations, the client may get confused and crash. Closes: coreos#4284
cgwalters
commented
May 11, 2023
| @@ -313,6 +313,99 @@ transaction_gpg_verify_result_cb (OstreeRepo *repo, const char *checksum, | |||
| g_strdup (checksum)); | |||
| } | |||
|
|
|||
| static void | |||
| transaction_output_cb (RpmOstreeOutputType type, void *data, void *opaque) | |||
There was a problem hiding this comment.
This function mostly just moved from sysroot_output_cb, with just some tweaks in the first section because we no longer need to check for a transaction being present, because we now only call this when we have a running one.
|
CI failure is not related |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/fcos-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because for transactions (which are always run in a thread today) we want output to go to the transaction's DBus progress. But for other methods which are not transactions, we don't have a channel for status reporting, so output needs to
continue to go to the journal. If we mix these two things due to
concurrent method invocations, the client may get confused and crash.
Closes: #4284