Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cci: Lower parallelism #4419

Closed
wants to merge 1 commit into from
Closed

cci: Lower parallelism #4419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .cci.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,14 @@ codestyle: {
}
}

def nhosts = 4
// Recently we're hitting soft lockup problems in CCI, so we have a pretty low parallelism here.
// xref https://github.com/coreos/coreos-assembler/pull/3450#issuecomment-1548496916
def nhosts = 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouff, 2 will have a very noticeable impact on CI time. WDYT about trying 4 + 1 (or + 2 even) first?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run from this PR took ~11 minutes: https://jenkins-coreos-ci.apps.ocp.fedoraproject.org/blue/organizations/jenkins/rpm-ostree/detail/PR-4419/1/pipeline/135

Some links from runs before this PR:

It's definitely looking like doing less in parallel is letting the individual test run notably faster; we're seemingly mostly I/O bound here.

(Which hmm...we should probably be using an explicitly ephemeral emptydir at least)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though the vmcheck run is consistently timing out now. Presumably we're less I/O bound there?

// Add an extra CPU for overhead
def ncpu = nhosts + 1
// Assume 1536 MB per instance, plus 512 overhead
def mem = (nhosts * 1536) + 512
cosaPod(runAsUser: 0, memory: "${mem}Mi", cpu: "${nhosts}") {
cosaPod(runAsUser: 0, memory: "${mem}Mi", cpu: "${ncpu}") {
stage("Unit Tests") {
checkout scm
unstash 'rpms'
Expand Down