Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run cosa unprivileged #4585

Merged
merged 1 commit into from
Sep 8, 2023
Merged

ci: Run cosa unprivileged #4585

merged 1 commit into from
Sep 8, 2023

Conversation

cgwalters
Copy link
Member

@cgwalters cgwalters commented Sep 7, 2023

@jlebon
Copy link
Member

jlebon commented Sep 7, 2023

Hmm IIRC, I don't think you can sudo at all without runAsUser: 0. Probably we should add a unprivshwrap() or something that switches to nonroot first. But for now, it should probably work to just do the cosa build as nonroot?

@cgwalters
Copy link
Member Author

Hmm IIRC, I don't think you can sudo at all without runAsUser: 0

You may be right (if I have to I'll extract the pod yaml and test this manually outside of PRs), but let's see if we can do it this way first, because it aligns more closely with other things (e.g. GH Actions).

But for now, it should probably work to just do the cosa build as nonroot?

Right, will try that next.

@cgwalters cgwalters changed the title ci/jenkins: Drop runAsUser: 0 ci: Run cosa unprivileged Sep 8, 2023
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 8, 2023
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 8, 2023
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 8, 2023
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 8, 2023
@cgwalters
Copy link
Member Author

/override ci/prow/fcos-e2e
Can't affect that

@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/fcos-e2e

In response to this:

/override ci/prow/fcos-e2e
Can't affect that

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member Author

continuous-integration/jenkins/pr-merge — This commit looks good

🎉

cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 8, 2023
@jlebon jlebon merged commit 5500157 into coreos:main Sep 8, 2023
17 checks passed
jlebon added a commit to jlebon/ostree that referenced this pull request Sep 9, 2023
jlebon added a commit to jlebon/ostree that referenced this pull request Sep 9, 2023
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 10, 2023
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 16, 2023
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 16, 2023
cgwalters added a commit to cgwalters/bootupd that referenced this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants