Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add doc about build rpm-ostree+autosd #4849

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

dougsland
Copy link
Contributor

Myself and Eric we spend a bunch of time to create rpm-ostree RPM for later inject it into autosd image. To avoid others to spend time in such effort, here a documentation.

Copy link

openshift-ci bot commented Feb 29, 2024

Hi @dougsland. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

docs/building-rpm-ostree-and-autosd.md Outdated Show resolved Hide resolved
docs/building-rpm-ostree-and-autosd.md Show resolved Hide resolved
docs/building-rpm-ostree-and-autosd.md Outdated Show resolved Hide resolved
docs/building-rpm-ostree-and-autosd.md Show resolved Hide resolved
docs/building-rpm-ostree-and-autosd.md Show resolved Hide resolved
docs/building-rpm-ostree-and-autosd.md Show resolved Hide resolved
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR I have no problem just merging this as is (it's better than not having it), but I think just a few cleanups would help.

@cgwalters
Copy link
Member

The other really popular thing in this space besides toolbx is vscode devcontainer but it's all proprietary.

@dougsland
Copy link
Contributor Author

FTR I have no problem just merging this as is (it's better than not having it), but I think just a few cleanups would
help.

I agree but If doesn't fit well, we can always use copy and past intogist githuburl.

@dougsland
Copy link
Contributor Author

@cgwalters I am open to do changes or improvements as you guys request, no problem at all. The next thing is do a full test against the changes from #4721 with this full environment working.

@ericcurtin
Copy link
Contributor

ericcurtin commented Mar 1, 2024

This generally LGTM, whether this belongs in Automotive documentation or here I don't mind.

Some of the techniques here are debatable, I think everyone may do a couple of these things differently.

One problem we had was the rpm generated on @dougsland 's machine had a lower version than on CentOS Stream 9 (this was the goal, to just generate an rpm with a higher version than in AutoSD).

So when we did final testing in an osbuild run, it wasn't getting pulled in.

The final test we always do is an osbuild run because that's the way rpm-ostree sets up things in the real-world case.

Although I wonder would a git fetch --tags have fixed the version number thing.

@ericcurtin
Copy link
Contributor

I do think a Containerfile and a simple shell script for local development to generate rpms would be helpful.

@dougsland dougsland force-pushed the documentation-generaterpm branch 3 times, most recently from cbeb107 to 913c445 Compare March 1, 2024 22:19
@dougsland
Copy link
Contributor Author

I believe I covered all requestes @cgwalters @ericcurtin

Myself and Eric we spend a bunch of time to create rpm-ostree
RPM for later inject it into autosd image. To avoid others to
spend time in such effort, here a documentation.

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Eric Curtin <ecurtin@redhat.com>
@dougsland dougsland force-pushed the documentation-generaterpm branch from 913c445 to 876143d Compare March 1, 2024 22:21
@cgwalters cgwalters merged commit 54047f8 into coreos:main Mar 1, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants