libpriv/scripts: support files in transfiletriggerin patterns #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Just quickly throwing this up; totally didn't test this but the CI test added should cover it.) |
cgwalters
approved these changes
Mar 14, 2024
The file trigger pattern isn't necessarily a directory. It seems just like a generic pattern applied to all file entries in the header of the packages being installed. (Technically we need to support globs in there too but we're currently not doing.) Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2269247
jlebon
force-pushed
the
pr/transfiletriggerin-file
branch
from
9051c54
to
220778e
Compare
|
Fixed a bug and confirmed this fixes https://bugzilla.redhat.com/show_bug.cgi?id=2269247. |
Merged
|
@jlebon: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file trigger pattern isn't necessarily a directory. It seems just like a generic pattern applied to all file entries in the header of the packages being installed. (Technically we need to support globs in there too but we're currently not doing.)
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2269247