Etc group members #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally I was trying to have all of the treefile parsing in treecompose, and then call other functions as API. But that turns out to be unrealistic. We'll need finer grained control over this in the future. Therefore, let's move the boot-location handling down, in preparation for further commits which parse the treefile in the commit phase.
Currently adding human users to a system group such as 'wheel' does
not work with shadow-utils as it exists now. This is admittedly
a hack; basically we single out "wheel" as going in /etc/group, via:
"etc-group-members": ["wheel"],
A more comprehensive solution to this will be:
coreos#49
|
Looks good to me. The only nit I saw (and it's a tiny one) was when using a GHashTable as a set like in _rpmostree_jsonutil_jsarray_strings_to_set(), it reads a little clearer to use g_hash_table_add() instead of g_hash_table_insert() or replace() with identical key and value. |
|
Ah right, thanks, fixed. On Mon, Nov 17, 2014, at 12:30 PM, Matthew Barnes wrote:
Links: |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.