rust/bwrap: log fusermount -u errors to stderr
#5046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe cosa is hitting an error in this code path, but we can't inspect the error because there's no journald running in supermin: coreos/coreos-assembler#3848 We don't gain much by printing this error to the journal since it shouldn't be very common. Print it on stderr instead where it's more likely to have visibility.
cgwalters
approved these changes
Aug 13, 2024
|
@jlebon: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
HuijingHei
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe cosa is hitting an error in this code path, but we can't inspect the error because there's no journald running in supermin:
coreos/coreos-assembler#3848
We don't gain much by printing this error to the journal since it shouldn't be very common. Print it on stderr instead where it's more likely to have visibility.