Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Continue to write now-empty rpmostree.modules metadata #5069

Merged
merged 1 commit into from
Aug 29, 2024
Merged

core: Continue to write now-empty rpmostree.modules metadata #5069

merged 1 commit into from
Aug 29, 2024

Conversation

cgwalters
Copy link
Member

Older versions of rpm-ostree bail if this isn't found. In practice we may as well keep this until the end of time...

Closes: #5048

@cgwalters
core: Continue to write now-empty rpmostree.modules metadata
d054672 
Older versions of rpm-ostree bail if this isn't found.
In practice we may as well keep this until the end of time...

Closes: coreos#5048
@cgwalters cgwalters mentioned this pull request Aug 27, 2024
Closed
HuijingHei
HuijingHei approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, sorry that can not verify as can not reproduce.

@cgwalters
Copy link
Member Author

Hmm...something seems to have pretty consistently broken DNS for dl.fedoraproject.org somehow in both of Jenkins and Prow?

@cgwalters
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 28, 2024

@cgwalters: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/fcos-e2e d054672 link true /test fcos-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@KyleGospo KyleGospo mentioned this pull request Aug 28, 2024
Merged
@jlebon
Copy link
Member

jlebon commented Aug 28, 2024

Pretty sure CI needs #5047. Right now there's a mismatch between rpm-ostree in FCOS and the one built in CI. FCOS lockfiles don't have fuse since that's not what rpm-ostree in Fedora requires. So it's not getting fetched.

@jlebon jlebon mentioned this pull request Aug 28, 2024
Merged
@cgwalters cgwalters merged commit fa51aa4 into coreos:main Aug 29, 2024
15 of 17 checks passed
@HuijingHei
Copy link
Member

Can reproduce on 40.20240825.20.0, start vm and install kmod-nvidia, then reboot, rebase older image like quay.io/fedora/fedora-coreos:stable and reboot.

Also verify the #5048 is fixed using the latest copr build rpm-ostree-2024.7.38.gcd6fd88b-1.fc40.x86_64 that includes this patch.

@HuijingHei HuijingHei mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuijingHei HuijingHei HuijingHei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpm-ostreed:ERROR:src/libpriv/rpmostree-util.cxx:510
3 participants
@cgwalters @jlebon @HuijingHei