Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Squash two minor build warnings #5070

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

cgwalters
Copy link
Member

  • Suppress a dead code warning on the tokio guard; it's just there for drop semantics.
  • Delete an unused function.

- Suppress a dead code warning on the tokio guard; it's just
  there for drop semantics.
- Delete an unused function.
Copy link

openshift-ci bot commented Aug 27, 2024

@cgwalters: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/fcos-e2e fa49448 link true /test fcos-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero disabled auto-merge August 29, 2024 15:05
@jmarrero jmarrero merged commit cd6fd88 into coreos:main Aug 29, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants