compose: Fix lookup of previous /etc/passwd #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I swear I tested this, but anyways coreos#79 wasn't quite right. We need to look at /usr/etc/{passwd,group} for previous data. We happily noticed there was no /etc/passwd in the tree, then proceeded to do the merge and split again, with the result of an empty /usr/etc/passwd in the new tree. That in turn resulted in an empty /etc/passwd in an installed system, i.e. with no "root" user, with obvious bad consequences, namely in my case crashing Anaconda. (Yes, I will write a testsuite for this)
|
Thinking about this, I realize what happened. I did test it, and it fixed the bug I was having, because I upgraded an existing system, which had a modified |
|
Makes sense to me. 👍 |
cgwalters
added a commit
that referenced
this pull request
Jan 7, 2015
compose: Fix lookup of previous /etc/passwd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I swear I tested this, but anyways
#79
wasn't quite right. We need to look at /usr/etc/{passwd,group}
for previous data.
We happily noticed there was no /etc/passwd in the tree, then
proceeded to do the merge and split again, with the result
of an empty /usr/etc/passwd in the new tree.
That in turn resulted in an empty /etc/passwd in an installed system,
i.e. with no "root" user, with obvious bad consequences, namely in my
case crashing Anaconda.
(Yes, I will write a testsuite for this)