unpacker: Translate /boot → /usr/lib/ostree-boot #969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At one point `rpm-ostree install libvirt` dragged in libguestfs which in turn brought in `syslinux-extlinux-nonlinux` which has files in `/boot/extlinux`, which we rejected. (That dependency chain appears to have been fixed currently) For the general case, this is just a partial fix in that we haven't nailed down the semantics of how updates for `/boot` work. But in this particular case, we'll just break libguestfs' `extlinux` verb, which I'm OK with. Another case is `fwupdate-efi` - we require manual intervention to copy the data into `/boot` after installing the package. This is also preparation for [unified core](coreos#729) in that we now ensure imported kernels don't end up in `/boot` unless explicitly configured. Closes: coreos#853
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 5, 2017
At one point `rpm-ostree install libvirt` dragged in libguestfs which in turn brought in `syslinux-extlinux-nonlinux` which has files in `/boot/extlinux`, which we rejected. (That dependency chain appears to have been fixed currently) For the general case, this is just a partial fix in that we haven't nailed down the semantics of how updates for `/boot` work. But in this particular case, we'll just break libguestfs' `extlinux` verb, which I'm OK with. Another case is `fwupdate-efi` - we require manual intervention to copy the data into `/boot` after installing the package. This is also preparation for [unified core](#729) in that we now ensure imported kernels don't end up in `/boot` unless explicitly configured. Closes: #853 Closes: #969 Approved by: jlebon
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-atomicjenkins |
miabbott
added a commit
to miabbott/atomic-host-tests
that referenced
this pull request
Oct 2, 2017
In projectatomic#254, it is noted that the package layering of `httpd` isn't working on CentOS because the `centos-logos` dependency is trying to layer files on `/boot`. Until CentOS gets a version of `rpm-ostree` that supports layering on `/boot` (see coreos/rpm-ostree#969), we need to use a different package to test package layering in CentOS. This change brings in a conditional installation of `ntp` in the CentOS case, until we have a newer version of `rpm-ostree` to use.
miabbott
added a commit
to miabbott/atomic-host-tests
that referenced
this pull request
Oct 5, 2017
In projectatomic#254, it is noted that the package layering of `httpd` isn't working on CentOS because the `centos-logos` dependency is trying to layer files on `/boot`. Until CentOS gets a version of `rpm-ostree` that supports layering on `/boot` (see coreos/rpm-ostree#969), we need to use a different package to test package layering in CentOS. This change brings in a conditional installation of `ntp` in the CentOS case, until we have a newer version of `rpm-ostree` to use.
mike-nguyen
pushed a commit
to projectatomic/atomic-host-tests
that referenced
this pull request
Oct 6, 2017
* roles: improve ability to check for un/installed packages The `rpm_ostree_install*` and `rpm_ostree_uninstall*` roles had some limitations when first created. Namely, only being able to be used once per playbook and being unable to check for a binary that did not match the package name. This changes the roles to use the `allow_duplicates` boolean, so that they may be used multiple times in the same playbook. The `*verify` roles have also been changed to allow for checking for a different binary name than what is used by the package. For example, the `ntp` package installs an `ntpd` binary, whereas the `httpd` package installs an `httpd` binary. * tests: handle package layering on CentOS In #254, it is noted that the package layering of `httpd` isn't working on CentOS because the `centos-logos` dependency is trying to layer files on `/boot`. Until CentOS gets a version of `rpm-ostree` that supports layering on `/boot` (see coreos/rpm-ostree#969), we need to use a different package to test package layering in CentOS. This change brings in a conditional installation of `ntp` in the CentOS case, until we have a newer version of `rpm-ostree` to use. * test/i-s-t: use conditionl vars from vars files This changes how the variables used by the `improved-sanity-test` are loaded in each playbook section. Commonly used variables are now found in `vars/common.yml` and are loaded for each playbook section. Additional variables that may change per OS platform, are broken out into separate files. By supplying a list of files to the `vars_files:` statement, Ansible will try to import each file in the list and stopping when a file is found.[0] This allows us to override any variables per OS while maintaing sensible defaults. [0] http://docs.ansible.com/ansible/latest/playbooks_conditionals.html#conditional-imports * roles/tests: handle shared variable namespace When running a role multiple times in a playbook, we can run into problems with variables since they all live in the same namespace. Notably, when you run a role multiple times, variables that are optional but have been defined, will carry over to the next execution of the role. Or if two roles have the same variable name, you can get values stomping on each other. This commit tries to alleviate some of these problems by updating the variable names in the roles to be unique to the role. Additionally, when using roles multiple times in playbooks, both required and optional variables are explicitly defined to avoid any overwriting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At one point
rpm-ostree install libvirtdragged in libguestfs which in turnbrought in
syslinux-extlinux-nonlinuxwhich has files in/boot/extlinux,which we rejected. (That dependency chain appears to have been fixed currently)
For the general case, this is just a partial fix in that we haven't nailed down
the semantics of how updates for
/bootwork. But in this particular case,we'll just break libguestfs'
extlinuxverb, which I'm OK with.Another case is
fwupdate-efi- we require manual intervention to copy thedata into
/bootafter installing the package.This is also preparation for unified core
in that we now ensure imported kernels don't end up in
/bootunlessexplicitly configured.
Closes: #853