-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
livefs: Update /usr/lib/{passwd,group}, run systemd-tmpfiles #996
Conversation
|
||
rpmostree_output_task_end ("done"); | ||
|
||
rpmostree_output_task_begin ("Running systemd-tmpfiles for /run,/var"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can easily make this conditional, right? We're already analyzing file paths before we being, so maybe let's look for tmpfiles.d
files too?
tests/vmcheck/test-livefs.sh
Outdated
@@ -65,16 +65,26 @@ vm_build_rpm test-livefs-with-etc \ | |||
/etc/%{name}/* | |||
/etc/opt/%{name}*" | |||
|
|||
# Simualte a service that adds a user and has data in tmpfiles.d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Simulate
cf8433f
to
94df4cd
Compare
This gets us to supporting live installs of `httpd` and many other services. I also tried `postgresql-server` for example. Closes: coreos#962
94df4cd
to
50a5abe
Compare
Rebased and updated to only run tmpfiles as needed. |
bot, retest this please |
/* Only dump stderr if it actually failed; otherwise we know | ||
* there are (harmless) warnings, no need to bother everyone. | ||
*/ | ||
sd_journal_print (LOG_ERR, "systemd-tmpfiles failed: %s", stderr_buf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should set an error too in this path, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Good catch. Fixup ⬇️
Hmm, that's odd.
|
Filed #1006 for that one. |
☀️ Test successful - status-atomicjenkins |
This gets us to supporting live installs of
httpd
and manyother services. I also tried
postgresql-server
for example.Closes: #962