livefs: Update /usr/lib/{passwd,group}, run systemd-tmpfiles #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Sep 18, 2017
|
|
||
| rpmostree_output_task_end ("done"); | ||
|
|
||
| rpmostree_output_task_begin ("Running systemd-tmpfiles for /run,/var"); |
There was a problem hiding this comment.
We can easily make this conditional, right? We're already analyzing file paths before we being, so maybe let's look for tmpfiles.d files too?
tests/vmcheck/test-livefs.sh
Outdated
| @@ -65,16 +65,26 @@ vm_build_rpm test-livefs-with-etc \ | |||
| /etc/%{name}/* | |||
| /etc/opt/%{name}*" | |||
|
|
|||
| # Simualte a service that adds a user and has data in tmpfiles.d | |||
cgwalters
force-pushed
the
livefs-passwd
branch
from
cf8433f
to
94df4cd
Compare
This gets us to supporting live installs of `httpd` and many other services. I also tried `postgresql-server` for example. Closes: coreos#962
cgwalters
force-pushed
the
livefs-passwd
branch
from
94df4cd
to
50a5abe
Compare
|
Rebased and updated to only run tmpfiles as needed. |
|
bot, retest this please |
jlebon
reviewed
Sep 25, 2017
| /* Only dump stderr if it actually failed; otherwise we know | ||
| * there are (harmless) warnings, no need to bother everyone. | ||
| */ | ||
| sd_journal_print (LOG_ERR, "systemd-tmpfiles failed: %s", stderr_buf); |
There was a problem hiding this comment.
We should set an error too in this path, right?
There was a problem hiding this comment.
Yes! Good catch. Fixup ⬇️
|
Hmm, that's odd. |
|
Filed #1006 for that one. |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us to supporting live installs of
httpdand manyother services. I also tried
postgresql-serverfor example.Closes: #962