This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
*: cleanup bazel rules #3137
Merged
*: cleanup bazel rules #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
most of the additions are actually the result of moving |
|
looking great to me, |
squat
force-pushed
the
finishtrack1cleanup
branch
from
2e3643c to
d61abd4
Compare
This commit cleans up several Bazel rules to remove mentions of code that was previously in the Track-1 flow of the Tectonic Installer.
enxebre
approved these changes
Mar 26, 2018
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jul 6, 2018
Catching up with d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137), which removed the root Makefile.
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jul 23, 2018
These used to be generated with terraform-docs, but the associated Makefile rule was removed without replacement in d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137). terraform-examples seems to have been similar, and its last Makefile reference was also removed in d61abd4. We may want to return to autogenerating examples/*.yaml at some point, but for now, stop claiming that we are autogenerating these.
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jul 25, 2018
1a49fbb (Move structure-check tools from Jenkinsfile to builder image, 2017-09-12, coreos/tectonic-installer#1889), added a: RUN go get github.com/s-urbaniak/terraform-examples to this Dockerfile. That package moved into the installer repository, but all we need for generation/testing is the terraform-examples binary, so a68555d (tests/ci: fix dockerfile and remove some layers, 2017-12-19, coreos/tectonic-installer#2600) removed the associated source with: RUN go get github.com/coreos/tectonic-installer/contrib/terraform-examples && \ rm -rf /go/src/github.com/coreos/tectonic-installer/ (i.e. "download github.com/coreos/tectonic-installer/contrib/terraform-examples, build terraform-examples, install it into $GOBIN, and remove the source"). d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137) removed the Makefile which had been calling terraform-examples, and 7c73c34 (remove terraform-examples from the tectonic-builder image, 2018-05-18, coreos/tectonic-installer#3239) removed the terraform-examples install from this Dockerfile. With the terraform-examples install removed, Go will no longer be downloading that source, so there's no longer any reason to remove it. This commit removes the unnecessary removal, which should make Dockerfile builds a bit faster and save an empty layer in the resulting images. More importantly, it avoids distracting future devs reading the Dockerfile source ;).
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jul 25, 2018
Most of the folks I've listed here are under Aaron in Red Hat, with Yifan being the installer lead. I've also included Alex and Clayton, who are higher up in Red Hat but still members of @openshift/installer. I'm guessing about roles, but we can always adjust later as we see fit. Approvers can also /lgtm [1], so there's no need to list them under 'reviewers' as well. The docs link in OWNERS is from [2]. While updating CONTRIBUTING.md to mention OWNERS (using wording based on [3]), I've also: * Added a line to make it clear that filing issues is helpful to (for folks who don't have the time or inclination to work up a PR). * Turned the unordered list into an ordered list. These entries happen sequentially, and an ordered list makes that more obvious. * Made "below" a link, to make finding the referenced content more convenient. * Shuffled words in the commit message format title to make it shorter. The references to 'make structure-check' are stale since d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137), but I've left fixing that to follow-up work. [1]: https://github.com/kubernetes/community/blob/4c0c2e9e659d2f989f3d23c3634c16bb099f3064/contributors/guide/owners.md#quirks-of-the-process [2]: kubernetes/kubernetes-template-project#15 [3]: https://github.com/kubernetes/kubernetes-template-project/blame/16f1588e6d4746876beb08cc64769657530d4872/CONTRIBUTING.md#L10
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 13, 2018
They haven't worked since d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137). Recommend out new hack/* scripts instead.
frobware
pushed a commit
to frobware/installer
that referenced
this pull request
Sep 17, 2018
1a49fbb (Move structure-check tools from Jenkinsfile to builder image, 2017-09-12, coreos/tectonic-installer#1889), added a: RUN go get github.com/s-urbaniak/terraform-examples to this Dockerfile. That package moved into the installer repository, but all we need for generation/testing is the terraform-examples binary, so a68555d (tests/ci: fix dockerfile and remove some layers, 2017-12-19, coreos/tectonic-installer#2600) removed the associated source with: RUN go get github.com/coreos/tectonic-installer/contrib/terraform-examples && \ rm -rf /go/src/github.com/coreos/tectonic-installer/ (i.e. "download github.com/coreos/tectonic-installer/contrib/terraform-examples, build terraform-examples, install it into $GOBIN, and remove the source"). d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137) removed the Makefile which had been calling terraform-examples, and 7c73c34 (remove terraform-examples from the tectonic-builder image, 2018-05-18, coreos/tectonic-installer#3239) removed the terraform-examples install from this Dockerfile. With the terraform-examples install removed, Go will no longer be downloading that source, so there's no longer any reason to remove it. This commit removes the unnecessary removal, which should make Dockerfile builds a bit faster and save an empty layer in the resulting images. More importantly, it avoids distracting future devs reading the Dockerfile source ;).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up several Bazel rules to remove mentions of code
that was previously in the Track-1 flow of the Tectonic Installer.
cc @enxebre @sym3tri @cpanato
This PR builds off of #3134 and removes all remaining mentions of track1 resources.