Just exit normally when booted into a container #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous work resulted in an error, but let's just exit with status zero because otherwise we end up tripping up things like checks for failing units. Anyone who has rebased into a container has very clearly taken explicit control over the wheel and there's no point in us erroring out. Closes: coreos#859
jlebon
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous work resulted in an error, but let's just exit with status zero because otherwise we end up tripping up things like checks for failing units.
Anyone who has rebased into a container has very clearly taken explicit control over the wheel and there's no point in us erroring out.