Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update README #167

Merged
merged 2 commits into from
Jun 29, 2023
Merged

chore: update README #167

merged 2 commits into from
Jun 29, 2023

Conversation

theseion
Copy link
Collaborator

  • update introduction
  • update documentation of autocomplete_headers

Follows #136.

@theseion theseion requested a review from fzipi June 25, 2023 06:09
fzipi
fzipi reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theseion Can you fix the conflict? From what I see it looks good

@theseion
chore: update README
7157ae0 
- update introduction
- update documentation of `autocomplete_headers`
@theseion
Copy link
Collaborator Author

Thanks for the reminder. I somehow missed that.

fzipi
fzipi requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small typo

README.md Outdated Show resolved Hide resolved
@theseion @fzipi
Fix typo
83d079b 
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
fzipi
fzipi approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@theseion theseion merged commit 2afd989 into coreruleset:main Jun 29, 2023
@theseion theseion deleted the update-readme branch June 29, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theseion @fzipi