Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce log level when writing headers #175

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

theseion
Copy link
Collaborator

@theseion theseion commented Aug 7, 2023

Multiple log entries are produced for each test, for each HTTP header written.

@theseion theseion requested a review from fzipi August 7, 2023 12:43
@theseion theseion force-pushed the reduce-log-level-when-writing-header branch from 0186a61 to 62038ae Compare August 7, 2023 12:53
ftwhttp/header.go Outdated Show resolved Hide resolved
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely and quiet.

@fzipi fzipi merged commit be45c06 into coreruleset:main Aug 14, 2023
@theseion theseion deleted the reduce-log-level-when-writing-header branch August 14, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants