Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix runner expected-error check potential panic #177

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

4lisalehi
Copy link
Contributor

Not sure if I'm using and testing the runner package correctly or not, but since expectedOutput.ExpectError is a pointer to boolean, dereferencing it is inherently unsafe and panic-able and depending on the behavior and outputs of go-ftw tests yaml deserialization, logically, it could panic in some cases and I believe this small change makes it a bit safer.

If I'm missing any point here, I'd appreciate your clarifying it.

Thanks.

@fzipi fzipi requested a review from theseion August 14, 2023 09:54
@theseion
Copy link
Collaborator

Thanks @4lisalehi. I'll look at your change soon.

@theseion theseion merged commit ceb4bc9 into coreruleset:main Aug 23, 2023
@theseion
Copy link
Collaborator

Thanks @4lisalehi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants