Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move test type to its own package #208

Merged
merged 6 commits into from
Nov 11, 2023
Merged

feat: move test type to its own package #208

merged 6 commits into from
Nov 11, 2023

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Nov 9, 2023

what

  • move internal test type to use external package

why

  • allow others to consume exported types
  • easy versioning on the yaml schema

fzipi and others added 2 commits November 9, 2023 12:10
@fzipi
feat: move test type to its own package
94fb167 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@M4tteoP
relies on external schema
3a4cb51
@M4tteoP
Copy link
Member

M4tteoP commented Nov 11, 2023

Currently depends on coreruleset/ftw-tests-schema#5 branch. It is meant to point to schema v1.1 before merging

@M4tteoP M4tteoP requested a review from theseion November 11, 2023 20:30
@M4tteoP M4tteoP marked this pull request as ready for review November 11, 2023 20:30
theseion
theseion requested changes Nov 11, 2023
View reviewed changes
test/defaults.go Outdated Show resolved Hide resolved
@theseion theseion merged commit a4cd40e into main Nov 11, 2023
3 checks passed
@theseion theseion deleted the use-external-ftw-yaml-schema branch November 11, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4tteoP M4tteoP M4tteoP left review comments

@theseion theseion theseion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fzipi @M4tteoP @theseion