Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handle multiple IDs in positive log match #298

Merged
merged 1 commit into from
May 11, 2024

Conversation

theseion
Copy link
Collaborator

The implementation for positive match of a list of IDs only required a single ID to match instead of all.

This commit also introduces memoization to minimize IO when searching the log.

Also fixed pre-commit config.

The implementation for positive match of a list of IDs only required a
single ID to match instead of all.

This commit also introduces memoization to minimize IO when searching
the log.

Also fixed pre-commit config.
@theseion theseion requested a review from fzipi May 11, 2024 10:45
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I hope that my IDE doesn't change imports back again. This is going to bite us in the future probably...

@theseion theseion merged commit bf760c8 into coreruleset:main May 11, 2024
3 checks passed
@theseion theseion deleted the gix-multi-id-log-match branch May 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants