Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve file loading robustness #310

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

theseion
Copy link
Collaborator

@theseion theseion commented Jun 1, 2024

Until now, go-ftw didn't know what to do with YAML files that were not test files. With the new platform override files (also YAML), it is very easy to also load them when globbing. This commit improves the output for such issues and continues execution, ignoring any files that can't be loaded.

Until now, go-ftw didn't know what to do with YAML files that were not
test files. With the new platform override files (also YAML), it is very
easy to also load them when globbing. This commit improves the output
for such issues and continues execution, ignoring any files that can't
be loaded.
@theseion theseion requested a review from fzipi June 1, 2024 06:58
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature!

@fzipi fzipi merged commit f35690f into coreruleset:main Jun 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants