Merge pull request #803 from dpfaffenbauer/index-arrays

[Index] introduce new abstract function to allow handling array data better for other providers
coreshop · Feb 4, 2019 · 2717661 · 2717661
2 parents 6cb9d85 + 6d952c3
commit 2717661
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/CoreShop/Bundle/IndexBundle/Worker/AbstractWorker.php b/src/CoreShop/Bundle/IndexBundle/Worker/AbstractWorker.php
@@ -192,7 +192,7 @@ protected function prepareData(IndexInterface $index, IndexableInterface $object
 
                 if (!$isLocalizedValue) {
                     if (is_array($value)) {
-                        $value = ',' . implode($value, ',') . ',';
+                        $value = $this->handleArrayValues($index, $value);
                     }
 
                     $value = $this->typeCastValues($column, $value);
@@ -229,6 +229,13 @@ protected function prepareData(IndexInterface $index, IndexableInterface $object
      */
     abstract protected function typeCastValues(IndexColumnInterface $column, $value);
 
+    /**
+     * @param IndexInterface $index
+     * @param array          $value
+     * @return mixed
+     */
+    abstract protected function handleArrayValues(IndexInterface $index, array $value);
+
     /**
      * @param IndexColumnInterface $column
      * @param IndexableInterface   $object

diff --git a/src/CoreShop/Bundle/IndexBundle/Worker/MysqlWorker.php b/src/CoreShop/Bundle/IndexBundle/Worker/MysqlWorker.php
@@ -274,6 +274,14 @@ protected function typeCastValues(IndexColumnInterface $column, $value)
         return $type->convertToDatabaseValue($value, $this->database->getDatabasePlatform());
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    protected function handleArrayValues(IndexInterface $index, array $value)
+    {
+        return ',' . implode($value, ',') . ',';
+    }
+
     /**
      * {@inheritdoc}
      */