Skip to content

Commit

Permalink
Merge pull request #1588 from dpfaffenbauer/issues/currency-context
Browse files Browse the repository at this point in the history
[Core] remove country-aware currency context as it messes with the Storage Based Currency Context
  • Loading branch information
dpfaffenbauer authored Apr 12, 2021
2 parents a1f2d58 + c51f5e1 commit 5f3694c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 64 deletions.
18 changes: 9 additions & 9 deletions features/currency/context.feature
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ Feature: Adding a new Currency
Scenario: Site should be using currency "USD"
And I am using currency "USD"
Then the site should be using currency "USD"

Scenario: Customer comes from Country "USA" and should use currency "USD"
And I am in country "USA"
Then the site should be using currency "USD"

Scenario: Customer comes from Country "USA" and should use currency "EUR"
Given the country "USA" is invalid for store "Austria"
And I am in country "USA"
Then the site should be using currency "EUR"
#
# Scenario: Customer comes from Country "USA" and should use currency "USD"
# And I am in country "USA"
# Then the site should be using currency "USD"CountryAwareCurrencyContext
#
# Scenario: Customer comes from Country "USA" and should use currency "EUR"
# Given the country "USA" is invalid for store "Austria"
# And I am in country "USA"
# Then the site should be using currency "EUR"
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ services:
- '@CoreShop\Component\Core\Context\Country\StoreAwareCountryContext.inner'
- '@coreshop.context.store'

coreshop.context.currency.country_currency_based: '@CoreShop\Component\Core\Context\Currency\CountryAwareCurrencyContext'
CoreShop\Component\Core\Context\Currency\CountryAwareCurrencyContext:
arguments:
- '@coreshop.context.country'
tags:
- { name: 'coreshop.context.currency' }

This file was deleted.

0 comments on commit 5f3694c

Please sign in to comment.