Merge pull request #833 from dpfaffenbauer/code-generator

[Order] fix code-generator length
coreshop · Feb 23, 2019 · 7fd32aa · 7fd32aa
2 parents f1407d5 + ee49c62
commit 7fd32aa
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/CoreShop/Component/Order/Generator/CartPriceRuleVoucherCodeGenerator.php b/src/CoreShop/Component/Order/Generator/CartPriceRuleVoucherCodeGenerator.php
@@ -102,7 +102,7 @@ protected static function generateCode($letters, $length)
         $i = 0;
         $code = '';
 
-        while ($i <= $length) {
+        while ($i < $length) {
             $num = rand() % 33;
             $tmp = substr($letters, $num, 1);
             $code = $code . $tmp;