-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Invoice Address is Shipping Address" checkbox results in form error #1257
Comments
ok, so that is only a UI problem right? |
Yes, UI as in the error cannot be seen, or maybe a "workflow" problem, that some invoice addresses may not be a shipping address too (if the checkbox is present, which is also UI-only?) |
Yes. I'd say thats just how you display things. Since the introduction of address-identifiers that problem can happen. Not sure how to solve properly.... Guess we should have a different select for addresses allowed for shipping as well and swap these two based on the checkbox. |
@GALCF could you please check the user: just open the cart customer, then open the address object from "default address". Is there a defined "address identifier"? |
@GALCF btw, we're using this in frontend: {% set hide_shipment_selector = hasShippableItems == false or (form.useInvoiceAsShipping is defined and form.useInvoiceAsShipping.vars.data and form.shippingAddress.vars.valid != false) %} instead of {% if hasShippableItems == true and form.useInvoiceAsShipping.vars.data %} which should be the default i think. |
I'll fix this in my latest PR (#1440). |
fixed |
Coreshop version 2.2.0 (current demo)
Pimcore version 6.4.2
While ordering with an invoice address that is not a shipping address, checking "Invoice Address is Shipping Address" and submitting the form results in a form error that is not shown because the checkbox hides the error with the shipping address input.
Expanded View (error not visible while checked):
The text was updated successfully, but these errors were encountered: