Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invoice Address is Shipping Address" checkbox results in form error #1257

Closed
GALCF opened this issue Feb 4, 2020 · 7 comments
Closed

"Invoice Address is Shipping Address" checkbox results in form error #1257

GALCF opened this issue Feb 4, 2020 · 7 comments
Assignees
Labels
Milestone

Comments

@GALCF
Copy link
Contributor

GALCF commented Feb 4, 2020

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Coreshop version 2.2.0 (current demo)
Pimcore version 6.4.2

While ordering with an invoice address that is not a shipping address, checking "Invoice Address is Shipping Address" and submitting the form results in a form error that is not shown because the checkbox hides the error with the shipping address input.

Expanded View (error not visible while checked):

image

@dpfaffenbauer
Copy link
Member

ok, so that is only a UI problem right?

@GALCF
Copy link
Contributor Author

GALCF commented Feb 5, 2020

Yes, UI as in the error cannot be seen, or maybe a "workflow" problem, that some invoice addresses may not be a shipping address too (if the checkbox is present, which is also UI-only?)

@dpfaffenbauer
Copy link
Member

Yes. I'd say thats just how you display things. Since the introduction of address-identifiers that problem can happen. Not sure how to solve properly.... Guess we should have a different select for addresses allowed for shipping as well and swap these two based on the checkbox.

@solverat
Copy link
Contributor

solverat commented Jul 1, 2020

@GALCF could you please check the user: just open the cart customer, then open the address object from "default address". Is there a defined "address identifier"?

image

@solverat
Copy link
Contributor

solverat commented Jul 1, 2020

@GALCF btw, we're using this in frontend:

{% set hide_shipment_selector = hasShippableItems == false or (form.useInvoiceAsShipping is defined and form.useInvoiceAsShipping.vars.data and form.shippingAddress.vars.valid != false) %}

instead of

{% if hasShippableItems == true and form.useInvoiceAsShipping.vars.data %}

which should be the default i think.

@solverat
Copy link
Contributor

solverat commented Jul 1, 2020

I'll fix this in my latest PR (#1440).

@dpfaffenbauer
Copy link
Member

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants