Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert default address type #1440

Merged
merged 4 commits into from
Jul 2, 2020
Merged

Conversation

solverat
Copy link
Contributor

@solverat solverat commented Jul 1, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? /no
Fixed tickets #1257

This PR will:

  • assert if a customers default address is valid within a given address identifier (We only have one default address, but multiple types of address identifier).
  • check if valid shipping addresses are available in address checkout step. if not, disable useInvoiceAsShipping checkbox since it is not possible to use it
  • add validation groups to the NotBlank constraints
  • Improve UI in address checkout step: if shippingAddress is not valid, show selector after page reloads.
  • If useInvoiceAsShipping has been checked, check if invoiceAddress can be assigned to shippingAddress first - if not, throw a proper exception. To be clear: This is just a development improvement to speed up the issue tracking time. The check itself should be done after a user selects an address (by JS for example).

@solverat solverat added the bug label Jul 1, 2020
@solverat solverat added this to the 2.2.3 milestone Jul 1, 2020
@solverat
Copy link
Contributor Author

solverat commented Jul 1, 2020

Also wrong, needs to be checked if invoiceAddress can be assigned to shippingAddress first!

$formData['shippingAddress'] = $formData['invoiceAddress'];

@dpfaffenbauer dpfaffenbauer self-requested a review July 2, 2020 14:34
@dpfaffenbauer dpfaffenbauer merged commit ce14ac5 into coreshop:2.2 Jul 2, 2020
@solverat solverat deleted the address_fix branch July 2, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants