[Admin Order detail] Carrier name not shown with legacy serialization of Orders

[ramundomario]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	yes/no

Carrier name is not shown in the shipment block in the admin order detail panel (Reproduced on latest demo).

Doing some debugging I noticed the carrierName is not present in the response if the coreshop.order.legacy_serialization parameter is true (default).

CoreShop/src/CoreShop/Bundle/OrderBundle/Controller/OrderController.php

Lines 348 to 383 in 8304171

	/**
	* @param OrderInterface $order
	*
	* @return array
	*/
	protected function getShipments($order)
	{
	$shipments = $this->getOrderShipmentRepository()->getDocuments($order);
	$shipmentArray = [];
	foreach ($shipments as $shipment) {
	$availableTransitions = $this->getWorkflowStateManager()->parseTransitions($shipment, 'coreshop_shipment', [
	'create',
	'ship',
	'cancel',
	], false);
	if ($this->useLegacySerialization()) {
	$data = $this->getDataForObject($shipment);
	foreach ($shipment->getItems() as $index => $item) {
	$data['items'][$index]['_itemName'] = $item->getOrderItem()->getName();
	}
	} else {
	$data = $this->getSerializer()->toArray($shipment);
	}
	$data['stateInfo'] = $this->getWorkflowStateManager()->getStateInfo('coreshop_shipment', $shipment->getState(), false);
	$data['transitions'] = $availableTransitions;
	$shipmentArray[] = $data;
	}
	return $shipmentArray;
	}

A solution would be to manually add the carrier identifier taken from the shipment if legacy serialization is true (default).
wdyt? @dpfaffenbauer
I could open a pull request

[dpfaffenbauer]

@ramundomario should be basically the same as here: https://github.com/coreshop/CoreShop/blob/master/src/CoreShop/Bundle/CoreBundle/Resources/config/serializer/Model.OrderShipment.yml#L7