Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Character Length Count in Voucher Code Generator #1194

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Fix Character Length Count in Voucher Code Generator #1194

merged 1 commit into from
Dec 2, 2019

Conversation

solverat
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets --

33 is a defined length for FORMAT_ALPHANUMERIC - if you're using FORMAT_ALPHABETIC or FORMAT_NUMERIC only, it will return null values which generates codes with wrong lengths.

@dpfaffenbauer dpfaffenbauer merged commit 793ef86 into coreshop:master Dec 2, 2019
@dpfaffenbauer
Copy link
Member

thanks

@solverat solverat deleted the voucher_fix branch December 2, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solverat @dpfaffenbauer