[Scrutinizer] remove unused-code

src/CoreShop/Bundle/CoreBundle/Controller/CoreSaleCreationTrait.php

@@ -78,13 +78,8 @@ public function getCarrierDetails(CartInterface $cart)
             $price = $this->get('coreshop.carrier.price_calculator.taxed')->getPrice(
                 $carrier,
                 $cart,
-            $cart->getShippingAddress()
-                );
-            $priceConverted = $this->get('coreshop.currency_converter')->convert(
-                $price,
-                $currentCurrency,
-            $cart->getCurrency()->getIsoCode()
-                );
+                $cart->getShippingAddress()
+            );
 
             $result[] = [
                 'id' => $carrier->getId(),

src/CoreShop/Bundle/FrontendBundle/Controller/SearchController.php

@@ -70,7 +70,7 @@ public function searchAction(Request $request)
 
     protected function createSearchForm()
     {
-        return $form = $this->get('form.factory')->createNamed('search', SearchType::class, null, [
+        return $this->get('form.factory')->createNamed('search', SearchType::class, null, [
             'action' => $this->generateCoreShopUrl(null, 'coreshop_search'),
             'method' => 'GET',
         ]);

src/CoreShop/Bundle/IndexBundle/Worker/AbstractWorker.php

@@ -303,7 +303,6 @@ protected function processGetter(IndexColumnInterface $column, IndexableInterfac
     {
         $getter = $column->getGetter();
         $getterClass = $this->getterServiceRegistry->get($getter);
-        $value = null;
 
         Assert::isInstanceOf($getterClass, GetterInterface::class);
 

src/CoreShop/Bundle/IndexBundle/Worker/MysqlWorker.php

@@ -300,7 +300,7 @@ protected function typeCastValueSQLDecleration(IndexColumnInterface $column)
      */
     protected function handleArrayValues(IndexInterface $index, array $value)
     {
-        return ',' . implode($value, ',') . ',';
+        return ',' . implode(',', $value) . ',';
     }
 
     /**

src/CoreShop/Bundle/OrderBundle/Controller/AbstractCartCreationController.php

@@ -187,7 +187,6 @@ protected function prepareCartItem(CartInterface $cart, CartItemInterface $item)
         $currency = $cart->getStore()->getCurrency()->getIsoCode();
 
         $moneyConverter = $this->get('coreshop.currency_converter');
-        $moneyFormatter = $this->get('coreshop.money_formatter');
 
         $price = $item->getItemPrice();
         $total = $item->getTotal();

src/CoreShop/Bundle/OrderBundle/Pimcore/Repository/CartRepository.php

@@ -126,7 +126,7 @@ public function findExpiredCarts($days, $anonymous, $customer)
         $params = [];
 
         $daysTimestamp = Carbon::now();
-        $daysTimestamp->subDay($days);
+        $daysTimestamp->subDays($days);
 
         $conditions[] = 'o_creationDate < ?';
         $params[] = $daysTimestamp->getTimestamp();

src/CoreShop/Bundle/TrackingBundle/Tracker/Matomo/Matomo.php

@@ -203,8 +203,6 @@ private function filterCategories($categories, int $limit = 5)
             return $categories;
         }
 
-        $result = null;
-
         if (is_array($categories)) {
             // add max 5 categories
             $categories = array_slice($categories, 0, 5);

src/CoreShop/Component/Address/Context/RequestBased/GeoLiteBasedRequestResolver.php

@@ -39,7 +39,6 @@ public function __construct(CountryRepositoryInterface $countryRepository)
     public function findCountry(Request $request)
     {
         $geoDbFile = PIMCORE_CONFIGURATION_DIRECTORY . '/GeoLite2-City.mmdb';
-        $record = null;
 
         if (file_exists($geoDbFile)) {
             try {

src/CoreShop/Component/Core/Notification/Rule/Action/Order/StoreMailActionProcessor.php

@@ -38,7 +38,6 @@ public function __construct(MailActionProcessor $mailActionProcessor)
      */
     public function apply($subject, NotificationRuleInterface $rule, array $configuration, $params = [])
     {
-        $language = null;
         $store = null;
         $mails = $configuration['mails'];
 

src/CoreShop/Component/Core/Notification/Rule/Action/Order/StoreOrderMailActionProcessor.php

@@ -37,7 +37,6 @@ public function __construct(OrderMailActionProcessor $orderMailActionProcessor)
      */
     public function apply($subject, NotificationRuleInterface $rule, array $configuration, $params = [])
     {
-        $language = null;
         $store = null;
         $mails = $configuration['mails'];
 

src/CoreShop/Component/Core/Order/Transformer/CartItemToSaleItemTransformer.php

@@ -47,7 +47,6 @@ public function transform(ProposalInterface $proposal, ProposalItemInterface $fr
         if ($fromProposalItem instanceof CartItemInterface && $toProposal instanceof SaleItemInterface) {
             $toProposal->setDigitalProduct($fromProposalItem->getDigitalProduct());
             $toProposal->setObjectId($fromProposalItem->getProduct()->getId());
-            $mainObjectId = null;
 
             if ($fromProposalItem->getProduct() instanceof ProductInterface) {
                 if ($fromProposalItem->getProduct()->getType() === AbstractObject::OBJECT_TYPE_VARIANT) {

src/CoreShop/Component/Core/Product/Calculator/StoreProductUnitDefinitionPriceCalculator.php

@@ -35,8 +35,6 @@ public function getRetailPrice(ProductInterface $subject, array $context)
         Assert::keyExists($context, 'store');
         Assert::isInstanceOf($context['store'], StoreInterface::class);
 
-        $price = null;
-
         if (!isset($context['unitDefinition']) || !$context['unitDefinition'] instanceof ProductUnitDefinitionInterface) {
             throw new NoRetailPriceFoundException(__CLASS__);
         }

src/CoreShop/Component/Pimcore/DataObject/ClassInstaller.php

@@ -21,11 +21,10 @@ class ClassInstaller implements ClassInstallerInterface
      */
     public function createBrick($jsonFile, $brickName)
     {
-        $objectBrick = null;
-
         try {
             $objectBrick = DataObject\Objectbrick\Definition::getByKey($brickName);
         } catch (\Exception $e) {
+            $objectBrick = null;
         }
 
         if (null === $objectBrick) {
@@ -97,11 +96,10 @@ public function createClass($jsonFile, $className, $updateClass = false)
      */
     public function createFieldCollection($jsonFile, $name)
     {
-        $fieldCollection = null;
-
         try {
             $fieldCollection = DataObject\Fieldcollection\Definition::getByKey($name);
         } catch (\Exception $e) {
+            $fieldCollection = null;
         }
 
         if (null === $fieldCollection) {

src/CoreShop/Component/Resource/DataHub/DoctrineProvider.php

@@ -117,7 +117,7 @@ public function initializeObjectType(ClassMetadataInfo $entityMetaType)
 
         foreach ($entityMetaType->getFieldNames() as $fieldName) {
             $fieldType = $this->mapFieldType($entityMetaType->getTypeOfField($fieldName));
-            $resolverClass = null;
+
             $resolver = new DoctrineField($fieldName, $fieldType);
             $fields[$fieldName] = $resolver->getDefinition();
             $inputFields[$fieldName] = array(