feature: calculate shipping tax using cart items

[lukadschaak]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets	-

Moin!
@dpfaffenbauer , do you remember the shipping tax calculation in germany? We spoke about that in the training and you implemented some stuff.

This PR implements the possibility to select a service, that will calculate the tax amount of the shipping price. In some countries the shipping price will have fix tax rate. In other countries, for example in Germany, the tax amount for the shipping cost is variable. It depends on the tax rate of the cart items. When all Items have the same tax rate, the shipping tax is the same (7% or 19%). If there are items with different tax rates in cart, it gets complicated.

With this Feature you can implement your own service and define your own tax calculation. Also the two ways of calculation are pre-implemented.

The Code is WIP. First of all i want to know if @dpfaffenbauer wants this feature in core and if you are happy with this way of implementing this feature. If yes i would finish the code and try to add tests.

On the following screen you see the combobox i added.

[dpfaffenbauer]

I'd much rather go a step further and would introduce shipping calculation strategies, where you can register services, these services gets displayed in a combobox and you can choose between them, wdyt?

[lukadschaak]

Like we start with our two strategies, and register them for example as service with the symfony tagging system? Then people are able to register their own service, which will then be displayed in the combobox?!
I think that sounds really nice. So every Country can select/implement his fitting service.

[dpfaffenbauer]

yep

[dpfaffenbauer]

BTW: If you are not sure how to implement it, we have several examples of how that is done in CoreShop. eg. CoreShop Index

[lukadschaak]

I will take a look at the current implementations and update this PR asap.

[lukadschaak]

What is the reason of adding the fields 'Stores' and 'Tax Rate' (see Screenshot of PR description) in ExtJS via panel.down("fieldset").add in a seperate item.js inside the CoreBundle?

src/CoreShop/Bundle/CoreBundle/Resources/public/pimcore/js/shipping/carrier/item.js

[dpfaffenbauer]

cause the shipping bundle doesn't know anything about stores nor taxes. only the core-bundle does

[lukadschaak]

General question. I'm thinking about naming and maybe ShippingTaxCaluculation would be more appropiate than ShippingTaxStrategy?!

[dpfaffenbauer]

ShippingTaxCalculationStrategy?

[lukadschaak]

Sounds good. I will do it

[dpfaffenbauer]

Is this ready to be reviewed and tested?

FYI: Travis currently fails cause Pimcore 6.5.2 is broken...

[dpfaffenbauer]

Just realised, this cannot be finished yet. Carrier Price Calculation also knows about tax and needs to use the tax-calc service as well, right?

[lukadschaak]

Just realised, this cannot be finished yet. Carrier Price Calculation also knows about tax and needs to use the tax-calc service as well, right?

Not sure where else the Carrier Price Calculation takes place. I just know of the CartProcessors which listen to cart updates. But yes, The Carrier price calculation always depends on these tax-calc services i think.

[dpfaffenbauer]

@solverat could you review that as well pls?

[dpfaffenbauer]

big thanks @lukadschaak