[IndexBundle] allow configuring if versions should be indexed or not #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dpfaffenbauer
commented
Feb 24, 2020
dpfaffenbauer
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
|
Tests fail due to Pimcore. Nothing I can currently do... still have to merge it though. |
jdreesen
reviewed
Feb 25, 2020
| use Doctrine\DBAL\Schema\Schema; | ||
| use Pimcore\Migrations\Migration\AbstractPimcoreMigration; | ||
|
|
||
| class Version20200224160300 extends AbstractPimcoreMigration |
There was a problem hiding this comment.
Why do you need two migrations doing the same (in different bundles)?
There was a problem hiding this comment.
cause of separation of bundles. When you install full-suite CoreShop, the IndexBundle is not installed, only the CoreBundle. If you only use the IndexBundle, you don't have the CoreBundle installed.... And since it's just migrations, I am happy with the duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.