Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with saving address changes #1408

Merged

Conversation

ramundomario
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

Fixed issue with saving address changes, reproducible on demo:
bug

Issue is caused by CustomerTransformHelper responsible for saving address, but saving is done only in case the address is new or parent is different.

// no affiliation has changed, return
if ($this->isNewEntity($address) === false && $address->getParent()->getId() === $newParent->getId()) {
return $address;
}

@CLAassistant
Copy link

CLAassistant commented May 22, 2020

CLA assistant check
All committers have signed the CLA.

@dpfaffenbauer dpfaffenbauer merged commit 38e438e into coreshop:2.2 May 27, 2020
@dpfaffenbauer
Copy link
Member

thanks

@solverat
Copy link
Contributor

@ramundomario nice catch! Thanks!

@ramundomario ramundomario deleted the bugfix/saving-address-changes branch May 27, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants