Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-add id reset on entity clone #1419

Merged
merged 2 commits into from
Jun 4, 2020
Merged

re-add id reset on entity clone #1419

merged 2 commits into from
Jun 4, 2020

Conversation

solverat
Copy link
Contributor

@solverat solverat commented Jun 3, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets --

Without resetting the id, entities won't get cloned. Instead the master entity data will just get moved.

@solverat solverat added the bug label Jun 3, 2020
@dpfaffenbauer dpfaffenbauer self-requested a review June 4, 2020 07:18
@dpfaffenbauer dpfaffenbauer added this to the 2.2.2 milestone Jun 4, 2020
@dpfaffenbauer dpfaffenbauer merged commit 6acc16e into coreshop:2.2 Jun 4, 2020
@solverat solverat deleted the unit_copy_fix branch June 4, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees

@solverat solverat

Labels
bug
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@solverat @dpfaffenbauer